Giter VIP home page Giter VIP logo

Comments (4)

fjtrujy avatar fjtrujy commented on May 25, 2024

When configuring SDL3_mixer using CMake, OpusFileConfig.cmake fails to include opusfileTargets.cmake. I'm using the ps2dev/ps2dev docker container.

 CMake Error at /usr/local/ps2dev/ps2sdk/ports/lib/cmake/opusfile/OpusFileConfig.cmake:74 (include):
  -- Using system opusfile
    include could not find requested file:
  
      /usr/local/ps2dev/ps2sdk/ports/lib/cmake/opusfile/opusfileTargets.cmake
  Call Stack (most recent call first):
    CMakeLists.txt:470 (find_package)

https://github.com/madebr/setup-sdl-test/actions/runs/7508233610/job/20443307429#step:5:69

Could it be a capitalization problem?
opusfileTargets.cmake vs OpusFileTargets.cmake

Screenshot 2024-03-26 at 13 32 37

We are also using this concrete hash for opusfile https://github.com/ps2dev/ps2sdk-ports/blob/master/build-cmakelibs.sh#L66

Let me know, if we are missing something here...
Cheers.

from ps2sdk.

fjtrujy avatar fjtrujy commented on May 25, 2024

It is indeed an issue in the opusFile library, more concretely it was done in this commit:
xiph/opusfile@856efa6

Where they forgot to also update this line:
https://github.com/xiph/opusfile/blob/master/cmake/OpusFileConfig.cmake.in#L50

I will create a PR for them.

Cheers.

from ps2sdk.

fjtrujy avatar fjtrujy commented on May 25, 2024

There was already a PR created for that: xiph/opusfile#42

from ps2sdk.

fjtrujy avatar fjtrujy commented on May 25, 2024

In the worst scenario, we can update opusfile in the ps2sdk-port to point just right before that guilty commit.
xiph/opusfile@81abcb7
Cheers

from ps2sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.