Giter VIP home page Giter VIP logo

Comments (2)

PeterDSteinberg avatar PeterDSteinberg commented on July 25, 2024

I could go either way on this one, @jdebacker . It doesn't seem terribly important to change. If we put all the B-Tax-specific parameters into a single dict argument that might provide some clarity for the new user with B-Tax parameter adjustments like the example above with btax_betr_pass, but if the new user just wants to do what is now:

run_btax(start_year, iit_reform)

(no B-Tax params), then they would have to add a third argument being a dict with no keys/values:

run_btax(start_year, iit_reform, {})

from cost-of-capital-calculator.

jdebacker avatar jdebacker commented on July 25, 2024

@PeterDSteinberg thanks for the feedback.

@MattHJensen I'm going to close this for now, unless you have thoughts given the push to have dictionaries of pre-pacakges reforms. My thinking is that such reforms would benefit from putting B-Tax specific parameters into a single dictionary, but perhaps you could weigh in on this.

from cost-of-capital-calculator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.