Using cattr_accessor is not thread safe about public_activity HOT 5 CLOSED

Thanks for reporting! Wasn't aware of such issue.

This gem needs a major overhaul with some new ideas I've came up ever since releasing it and will fix it then.

from public_activity.

@pokonski what is the progress on the overhaul? :-)

from public_activity.

@bjensen good question. I'm open for suggestions! The best idea I had so far is solving this by allowing people to supply lambdas/Procs in the defaults hash. So this would be possible:

class Article < ActiveRecord::Base
  tracked :params => {current_user: Proc.new{|controller| controller.current_user} }
end

Currently slowly working on 0.4.0 version which is going to be a major rewrite, but that will take some time.

from public_activity.

Currently, we store the controller in Thread.current, but I could use the technique from that blog post:

class BetterThreadedLibrary
  @@some_setting = Hash.new {|h,k| h[k] = :default }
  def self.some_setting=(val)
    @@some_setting[Thread.current.object_id] = val
  end
  def self.some_setting
    @@some_setting[Thread.current.object_id]
  end
end

however, I have to come up with a solution that works on 1.8.7 aswell and instruct garbage collector to clean up when the thread dies

from public_activity.

So is the gem in the current state (master branch) thread safe?

from public_activity.