Comments (20)
jywarren
commented on July 29, 2024
2
that'd be great!!
…On Wed, Feb 21, 2018 at 1:51 PM, Sagarpreet Chadha ***@***.*** > wrote:
Hi @jywarren <https://github.com/jywarren> , can i try to solve this one
? Thanks !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJynHu3igyhZuk7A8lhcGDmcTOHQaks5tXGV_gaJpZM4QNbHD>
.
from leaflet-blurred-location.
mridulnagpal
commented on July 29, 2024
1
Is this done?
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
Hi, @mridulnagpal - do you have any time to try taking this one on? I'd like to complete this and release a new version!
from leaflet-blurred-location.
mridulnagpal
commented on July 29, 2024
On it right away !!
…On 05-Jan-2018 3:01 AM, "Jeffrey Warren" ***@***.***> wrote:
Hi, @mridulnagpal <https://github.com/mridulnagpal> - do you have any
time to try taking this one on? I'd like to complete this and release a new
version!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVULlKtYpgXLibHqRFc03YTZAi4Q0bLRks5tHUMSgaJpZM4QNbHD>
.
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
Awesome!!!
…On Jan 4, 2018 11:43 PM, "Mridul Nagpal" ***@***.***> wrote:
On it right away !!
On 05-Jan-2018 3:01 AM, "Jeffrey Warren" ***@***.***> wrote:
> Hi, @mridulnagpal <https://github.com/mridulnagpal> - do you have any
> time to try taking this one on? I'd like to complete this and release a
new
> version!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/publiclab/leaflet-blurred-location/
issues/105#issuecomment-355404312>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AVULlKtYpgXLibHqRFc03YTZAi4Q0bLRks5tHUMSgaJpZM4QNbHD>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_e2MUOY8EXsu6x83sujPaThrQUiks5tHag8gaJpZM4QNbHD>
.
from leaflet-blurred-location.
mridulnagpal
commented on July 29, 2024
Isn't it called at the end of the setBlurred method already?
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
I think we need to visually see the decimals truncated under By entering co-ordinates -- so there's clear feedback to the user that blurring is now on -- and to ensure that the truncated digits don't get submitted, right? Thank you, Mridul!
from leaflet-blurred-location.
mridulnagpal
commented on July 29, 2024
Awesome!!
from leaflet-blurred-location.
sagarpreet-chadha
commented on July 29, 2024
Hi @jywarren , can i try to solve this one ? Thanks !
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
Hi! I just want to re-open this because it seems that while unchecking will return to full resolution, once you then start to drag, it gets stuck in the previous state.
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
So when you uncheck "blurred" it shows very precise coordinates, but then dragging the map blurs the location again even though the checkbox is not checked!
from leaflet-blurred-location.
sagarpreet-chadha
commented on July 29, 2024
Extremely sorry !
Thats strange , the changes works fine on my local project . Will try to fix this ASAP .
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
Np! It happens, thanks!!
…On Wed, Mar 14, 2018, 11:14 AM Sagarpreet Chadha ***@***.***> wrote:
Extremely sorry !
Thats strange , the changes works fine on my local project . Will try to
fix this ASAP .
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ6rhtnjq5h77VCfEZVnnUMKP97Kqks5teTOdgaJpZM4QNbHD>
.
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
I believe this is still an issue -- I confirmed in the demo. @mridulnagpal would you have some time to try this and see if we can ensure the blurring of the actual numbers displayed gets shown when the blur checkbox is unchecked?
from leaflet-blurred-location.
mridulnagpal
commented on July 29, 2024
Sure on it!!
from leaflet-blurred-location.
mridulnagpal
commented on July 29, 2024
@jywarren So basically we should show full lat/lng when setBlurred is unchecked right?
from leaflet-blurred-location.
mridulnagpal
commented on July 29, 2024
Is this good?
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
yeah exactly!
…On Fri, Jun 8, 2018 at 12:13 PM Mridul Nagpal ***@***.***> wrote:
Is this good?
[image: recalculation]
<https://user-images.githubusercontent.com/22350740/41168892-dce737d6-6b64-11e8-9931-c753f8296a8a.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ453pbzuNb06zUw_utHfCY2vuZ7iks5t6qKIgaJpZM4QNbHD>
.
from leaflet-blurred-location.
mridulnagpal
commented on July 29, 2024
Awesome lets merge it then!!
from leaflet-blurred-location.
jywarren
commented on July 29, 2024
Yes!!! 👍
from leaflet-blurred-location.
Related Issues (20)
- Restrict out of range input HOT 1
- Make LBL object syntax same as that of standard leaflet object .
- [Bug] TypeError: getBlurryScale(...) is undefined .
- Weekly Community Check-in #19 - Express gratitude :-) HOT 43
- Development of a "blurred location" specification/standard
- Add CONTRIBUTING.md HOT 8
- Remove Bower support HOT 6
- Grid box selection not working between 1W and 0 degrees longitude
- Location search not working HOT 33
- Open a ISSUE TEMPLATE [ First Timers Only ] HOT 8
- Create getZoom function HOT 1
- Create getZoomFromCoordinates function HOT 18
- Add new functions to README HOT 3
- Weekly community Check-In #42 - Happy Holidays HOT 18
- Slider doesn't update when map is zoomed with other methods
- Geocode reverse lookup in getPlacenameFromCoordinates not working HOT 1
- Testing errors - ReferenceError: Can't find variable: google HOT 9
- Weekly community Check-In #50 - Favorite text editors HOT 16
- Mapknitter API change
- Demo problem
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from leaflet-blurred-location.