Giter VIP home page Giter VIP logo

Comments (4)

nmorsman avatar nmorsman commented on June 8, 2024

Hi,

While replacing axios isn't currently on the roadmap, I'll make sure to keep it in mind for a future major release.

Regarding the error you are experiencing while using jest it seems like this is a common issue with axios. I've implemented a fix for this in 70de66f by explicitly setting Node as the default HTTP adapter, because, as you said, there is no reason for axios to select the browser adapter in this client.

Will publish with v4.0.2 and ping once done.

Thanks!

from node-acme-client.

silverwind avatar silverwind commented on June 8, 2024

Great, thanks. I can recommend either make-fetch-happen or my fetch-enhanced for fetch implementations that support automatic http proxy discovery which is a quite important feature in enterprise environments (Thought I guess in most cases, a application that does ACME challenges will have some form of direct internet connectivity).

from node-acme-client.

nmorsman avatar nmorsman commented on June 8, 2024

Fix published with v4.0.2!

from node-acme-client.

silverwind avatar silverwind commented on June 8, 2024

Maybe you want to consider using undici.fetch. It's also available as (experimental) global fetch starting with Node.js 18.

from node-acme-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.