Giter VIP home page Giter VIP logo

Comments (1)

justinvp avatar justinvp commented on September 27, 2024

Hi @sam-drew. Thanks for opening the issue and sorry for the trouble.

It looks like the converter is having trouble with a couple of variables in this module. If I comment out the problematic variables, I can get the converter to succeed. From there, there are still manual fix-ups to work through, but the converter can save a ton of time converting TF to Pulumi vs. doing it manually.

diff --git a/main.tf b/main.tf
index 645bb6d2..219d69c2 100644
--- a/main.tf
+++ b/main.tf
@@ -287,7 +287,7 @@ module "runners" {
   pool_runner_owner                          = var.pool_runner_owner
   pool_lambda_reserved_concurrent_executions = var.pool_lambda_reserved_concurrent_executions
 
-  ssm_housekeeper = var.runners_ssm_housekeeper
+  # ssm_housekeeper = var.runners_ssm_housekeeper
 }
 
 module "runner_binaries" {
diff --git a/modules/multi-runner/runners.tf b/modules/multi-runner/runners.tf
index 859e477e..0479b6f9 100644
--- a/modules/multi-runner/runners.tf
+++ b/modules/multi-runner/runners.tf
@@ -109,5 +109,5 @@ module "runners" {
   pool_lambda_reserved_concurrent_executions = var.pool_lambda_reserved_concurrent_executions
   associate_public_ipv4_address              = var.associate_public_ipv4_address
 
-  ssm_housekeeper = var.runners_ssm_housekeeper
+  # ssm_housekeeper = var.runners_ssm_housekeeper
 }
diff --git a/modules/multi-runner/variables.tf b/modules/multi-runner/variables.tf
index efdbfd82..ce601d32 100644
--- a/modules/multi-runner/variables.tf
+++ b/modules/multi-runner/variables.tf
@@ -588,29 +588,29 @@ variable "associate_public_ipv4_address" {
   default     = false
 }
 
-variable "runners_ssm_housekeeper" {
-  description = <<EOF
-  Configuration for the SSM housekeeper lambda. This lambda deletes token / JIT config from SSM.
-
-  `schedule_expression`: is used to configure the schedule for the lambda.
-  `enabled`: enable or disable the lambda trigger via the EventBridge.
-  `lambda_memory_size`: lambda memery size limit.
-  `lambda_timeout`: timeout for the lambda in seconds.
-  `config`: configuration for the lambda function. Token path will be read by default from the module.
-  EOF
-  type = object({
-    schedule_expression = optional(string, "rate(1 day)")
-    enabled             = optional(bool, true)
-    lambda_memory_size  = optional(number, 512)
-    lambda_timeout      = optional(number, 60)
-    config = object({
-      tokenPath      = optional(string)
-      minimumDaysOld = optional(number, 1)
-      dryRun         = optional(bool, false)
-    })
-  })
-  default = { config = {} }
-}
+# variable "runners_ssm_housekeeper" {
+#   description = <<EOF
+#   Configuration for the SSM housekeeper lambda. This lambda deletes token / JIT config from SSM.
+
+#   `schedule_expression`: is used to configure the schedule for the lambda.
+#   `enabled`: enable or disable the lambda trigger via the EventBridge.
+#   `lambda_memory_size`: lambda memery size limit.
+#   `lambda_timeout`: timeout for the lambda in seconds.
+#   `config`: configuration for the lambda function. Token path will be read by default from the module.
+#   EOF
+#   type = object({
+#     schedule_expression = optional(string, "rate(1 day)")
+#     enabled             = optional(bool, true)
+#     lambda_memory_size  = optional(number, 512)
+#     lambda_timeout      = optional(number, 60)
+#     config = object({
+#       tokenPath      = optional(string)
+#       minimumDaysOld = optional(number, 1)
+#       dryRun         = optional(bool, false)
+#     })
+#   })
+#   default = { config = {} }
+# }
 
 variable "metrics_namespace" {
   description = "The namespace for the metrics created by the module. Merics will only be created if explicit enabled."
diff --git a/modules/runners/variables.tf b/modules/runners/variables.tf
index 82fd2cf9..b2602216 100644
--- a/modules/runners/variables.tf
+++ b/modules/runners/variables.tf
@@ -632,29 +632,29 @@ variable "associate_public_ipv4_address" {
   default     = false
 }
 
-variable "ssm_housekeeper" {
-  description = <<EOF
-  Configuration for the SSM housekeeper lambda. This lambda deletes token / JIT config from SSM.
-
-  `schedule_expression`: is used to configure the schedule for the lambda.
-  `state`: state of the cloudwatch event rule. Valid values are `DISABLED`, `ENABLED`, and `ENABLED_WITH_ALL_CLOUDTRAIL_MANAGEMENT_EVENTS`.
-  `lambda_memory_size`: lambda memery size limit.
-  `lambda_timeout`: timeout for the lambda in seconds.
-  `config`: configuration for the lambda function. Token path will be read by default from the module.
-  EOF
-  type = object({
-    schedule_expression = optional(string, "rate(1 day)")
-    state               = optional(string, "ENABLED")
-    lambda_memory_size  = optional(number, 512)
-    lambda_timeout      = optional(number, 60)
-    config = object({
-      tokenPath      = optional(string)
-      minimumDaysOld = optional(number, 1)
-      dryRun         = optional(bool, false)
-    })
-  })
-  default = { config = {} }
-}
+# variable "ssm_housekeeper" {
+#   description = <<EOF
+#   Configuration for the SSM housekeeper lambda. This lambda deletes token / JIT config from SSM.
+
+#   `schedule_expression`: is used to configure the schedule for the lambda.
+#   `state`: state of the cloudwatch event rule. Valid values are `DISABLED`, `ENABLED`, and `ENABLED_WITH_ALL_CLOUDTRAIL_MANAGEMENT_EVENTS`.
+#   `lambda_memory_size`: lambda memery size limit.
+#   `lambda_timeout`: timeout for the lambda in seconds.
+#   `config`: configuration for the lambda function. Token path will be read by default from the module.
+#   EOF
+#   type = object({
+#     schedule_expression = optional(string, "rate(1 day)")
+#     state               = optional(string, "ENABLED")
+#     lambda_memory_size  = optional(number, 512)
+#     lambda_timeout      = optional(number, 60)
+#     config = object({
+#       tokenPath      = optional(string)
+#       minimumDaysOld = optional(number, 1)
+#       dryRun         = optional(bool, false)
+#     })
+#   })
+#   default = { config = {} }
+# }
 
 variable "enable_on_demand_failover_for_errors" {
   description = "Enable on-demand failover. For example to fall back to on demand when no spot capacity is available the variable can be set to `InsufficientInstanceCapacity`. When not defined the default behavior is to retry later."
diff --git a/variables.tf b/variables.tf
index 51bd7d8e..85dae79f 100644
--- a/variables.tf
+++ b/variables.tf
@@ -828,29 +828,29 @@ variable "associate_public_ipv4_address" {
   default     = false
 }
 
-variable "runners_ssm_housekeeper" {
-  description = <<EOF
-  Configuration for the SSM housekeeper lambda. This lambda deletes token / JIT config from SSM.
-
-  `schedule_expression`: is used to configure the schedule for the lambda.
-  `enabled`: enable or disable the lambda trigger via the EventBridge.
-  `lambda_memory_size`: lambda memery size limit.
-  `lambda_timeout`: timeout for the lambda in seconds.
-  `config`: configuration for the lambda function. Token path will be read by default from the module.
-  EOF
-  type = object({
-    schedule_expression = optional(string, "rate(1 day)")
-    enabled             = optional(bool, true)
-    lambda_memory_size  = optional(number, 512)
-    lambda_timeout      = optional(number, 60)
-    config = object({
-      tokenPath      = optional(string)
-      minimumDaysOld = optional(number, 1)
-      dryRun         = optional(bool, false)
-    })
-  })
-  default = { config = {} }
-}
+# variable "runners_ssm_housekeeper" {
+#   description = <<EOF
+#   Configuration for the SSM housekeeper lambda. This lambda deletes token / JIT config from SSM.
+
+#   `schedule_expression`: is used to configure the schedule for the lambda.
+#   `enabled`: enable or disable the lambda trigger via the EventBridge.
+#   `lambda_memory_size`: lambda memery size limit.
+#   `lambda_timeout`: timeout for the lambda in seconds.
+#   `config`: configuration for the lambda function. Token path will be read by default from the module.
+#   EOF
+#   type = object({
+#     schedule_expression = optional(string, "rate(1 day)")
+#     enabled             = optional(bool, true)
+#     lambda_memory_size  = optional(number, 512)
+#     lambda_timeout      = optional(number, 60)
+#     config = object({
+#       tokenPath      = optional(string)
+#       minimumDaysOld = optional(number, 1)
+#       dryRun         = optional(bool, false)
+#     })
+#   })
+#   default = { config = {} }
+# }
 
 variable "metrics_namespace" {
   description = "The namespace for the metrics created by the module. Merics will only be created if explicit enabled."

I'll keep this issue open to track addressing the underlying issue.

from pulumi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.