Comments (5)
garethr
commented on June 29, 2024
@aaron-grewell apologies, I'll get that fixes. I've been slightly over zealous in fixing a style issue in c4e6991#diff-5b6bb399d2fbcb9e0c09e42aa7ac6512
from puppetlabs-image_build.
garethr
commented on June 29, 2024
I've a PR up for this in #37. We'll get that merged and a new release pushed to the Forge.
from puppetlabs-image_build.
aaron-grewell
commented on June 29, 2024
Thanks Gareth! That definitely seemed to do the trick. I was going to suggest that test coverage include centos but it looks like it should. At least the acceptance tests include a centos node (apologies, my spec-fu is weak). It's surprising to me that it wasn't picked up by the tests.
from puppetlabs-image_build.
garethr
commented on June 29, 2024
I've added unit tests to that PR that will trigger the issue in Travis too, which should prevent this in the future. Thanks for checking out the issue.
from puppetlabs-image_build.
garethr
commented on June 29, 2024
Fixed in #37
from puppetlabs-image_build.
Related Issues (20)
- Entrypoint array missing commas HOT 2
- set show diff optional HOT 1
- Build not failing on apply failures HOT 5
- Build w/ Docker master on Mac isn't actually.. easy. HOT 3
- Pass `--debug` to puppet apply HOT 1
- Add `--tag`option HOT 1
- Error: No such file or directory - fork failed HOT 1
- Got permission denied while trying to connect to the Docker daemon socket HOT 1
- Add Support for base images build on supported base images HOT 2
- Puppet 5 support HOT 1
- Docker multistage build HOT 1
- Building from master - not doing anything? HOT 5
- Missing license HOT 1
- Hooks to Extend Dockerfile
- Support Additional Puppet Argument, e.g. `--environment` HOT 2
- Missing Tag in Repo HOT 1
- Error building images when in metadata file is used centos as parameter for "from" field
- Is this module still being maintained? HOT 1
- Debian buster support not working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppetlabs-image_build.