Comments (6)
If it helps, I generated a module with the steps necessary to demonstrate the issue at https://github.com/silug/issue_543.
from pdk-templates.
thanks for raising this @silug.
I've raised #544, if you get a moment could you update the template ref to that PR branch
"template-url": "https://github.com/puppetlabs/pdk-templates#gh-543-fix_networking_facts_merge",
"template-ref": "remotes/origin/gh-543-fix_networking_facts_merge-0-gcb66796"
run pdk update
and let me know how that works out?
Thanks again
from pdk-templates.
@jordanbreen28 That change does not appear to affect the behavior. I'm guessing the add_custom_fact
function is where the change needs to happen. I'm not sure where that's coming from though.
from pdk-templates.
@jordanbreen28 That change does not appear to affect the behavior. I'm guessing the
add_custom_fact
function is where the change needs to happen. I'm not sure where that's coming from though.
@silug From what I can see, add_custom_fact
is being pulled in from rspec-puppet-facts.
What's good is your initial point still stands, we definitely should have been deep merging by default in spec_helper.rb.erb
to allow using nested facts in default_facts.yml without overriding the entire fact, so thanks for bringing that up.
Just need to get thinking about the best way to proceed here.
It's an interesting one; nice catch!
from pdk-templates.
@silug fwiw I had raised this before, but we paused it due to some unexpected behaviour we were seeing.
Looks like we may need to pick it back up
from pdk-templates.
Just hit that with PDK templates v3.0.1. Can we maybe delete the default_facts.yml
completely and suggest to use rspec-puppet-facts
way by default?
from pdk-templates.
Related Issues (20)
- Enable puppet-lint-plugins also on Windows HOT 1
- Enhance templates to handle rules in .gitlab-ci.yml section of sync.yml HOT 1
- GitLab CI is failing due to rubocop-ast dependency under puppet6 HOT 1
- When honeycomb is disabled command `buildevents` is not known, but still used in github actions scripts HOT 1
- Update the auto_release workflow to include the REFERENCE.md generate command
- set/allow interruptible in gitlabci jobs
- Custom .gitlab-ci.yml settings for litmus not working as expected HOT 1
- `disable_legacy_facts: true` includes deprecated puppet-lint-legacy_facts-check gem HOT 5
- Cannot load puppet_blacksmith on fresh module HOT 3
- facter_implementation missing quotes HOT 2
- Cannot load github_changelog_generator/task HOT 1
- Allow puppet-lint fail_on_warnings to be explicitly disabled
- .gitlab-cy.yml missing in pdk-templates 3.0? HOT 6
- Wrong things added? HOT 2
- Should PDK also work with templates on our internal GitHub Enterprise? HOT 2
- Integrate with Vox Pupuli HOT 1
- Implement allow list for .pmtignore HOT 1
- Adjust with the new puppet specifications for module layouts HOT 1
- removal of github changelog also removed @configs['extras']] hanlding in Rakefile
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pdk-templates.