networking key in default_facts.yml masks all values from rspec-puppet-facts about pdk-templates HOT 6 CLOSED

If it helps, I generated a module with the steps necessary to demonstrate the issue at https://github.com/silug/issue_543.

from pdk-templates.

thanks for raising this @silug.
I've raised #544, if you get a moment could you update the template ref to that PR branch

  "template-url": "https://github.com/puppetlabs/pdk-templates#gh-543-fix_networking_facts_merge",
  "template-ref": "remotes/origin/gh-543-fix_networking_facts_merge-0-gcb66796"

run pdk update and let me know how that works out?
Thanks again

from pdk-templates.

@jordanbreen28 That change does not appear to affect the behavior. I'm guessing the add_custom_fact function is where the change needs to happen. I'm not sure where that's coming from though.

from pdk-templates.

@jordanbreen28 That change does not appear to affect the behavior. I'm guessing the add_custom_fact function is where the change needs to happen. I'm not sure where that's coming from though.

@silug From what I can see, add_custom_fact is being pulled in from rspec-puppet-facts.

What's good is your initial point still stands, we definitely should have been deep merging by default in spec_helper.rb.erb to allow using nested facts in default_facts.yml without overriding the entire fact, so thanks for bringing that up.

Just need to get thinking about the best way to proceed here.

It's an interesting one; nice catch!

from pdk-templates.

@silug fwiw I had raised this before, but we paused it due to some unexpected behaviour we were seeing.
Looks like we may need to pick it back up

from pdk-templates.

Just hit that with PDK templates v3.0.1. Can we maybe delete the default_facts.yml completely and suggest to use rspec-puppet-facts way by default?

from pdk-templates.