Comments (6)
Ah, good to hear. I'm at a conference early this week, but I should be able to bang this out Thursday or Friday when I get back. The refactor is done, it's just the tests that need rewriting.
from puppetlabs-kubernetes.
@davejrt @scotty-c: I have a fix for my issues in the https://github.com/temujin9/puppetlabs-kubernetes/tree/neliot-fix-param-inheritance branch. However, this fix eliminates kubernetes::params (whose invocation order was causing the defaulting problem). Can you look at it, and tell me if that kind of fix is acceptable, and if not maybe suggest a different approach?
from puppetlabs-kubernetes.
I also trembled on this, my fix was to move the version var and the two depending to the main class, keeping the rest in the params
from puppetlabs-kubernetes.
@temujin9 I am happy to look at a PR that brings the data back into the module as is suggested in the best practices now.
from puppetlabs-kubernetes.
Ah, turns out my fix takes no correction at all. The test failures occur under the new default puppet version of 6.0.2, with or without my changes.
Setting PUPPET_GEM_VERSION="~> 5.5.7" makes test pass both before and after my change. I'll PR shortly, and then ticket this 6.0.2 issue (which is not a priority from our perspective).
from puppetlabs-kubernetes.
Actually, I notice that the most recent master is now pinned to 5.5.6, so I suspect you already know the issue. Let me know if you want me to ticket it.
from puppetlabs-kubernetes.
Related Issues (20)
- Config version not set correctly
- Variable kubernetes::containerd_config_source is not honored HOT 2
- Support for RedHat derivatives version 8 and 9 HOT 2
- Invalid default docker version on Debian HOT 2
- Spec tests seem to be broken and are blocking PRs HOT 2
- Calico install doesn't work HOT 3
- Module not work HOT 31
- CNI commands aren't executed HOT 3
- Containerd won't bind GRPC endpoint HOT 2
- docker commands fail with errors HOT 2
- puppet/kubetool:7.0.0 - bad discovery_token_hash HOT 3
- Version bump for puppet/kubetool ? HOT 1
- deprecate this module in favour of puppet/k8s HOT 8
- Version bump for kubetool? HOT 2
- Minimum puppet version for puppetlabs-kubernetes 7.1.1 HOT 1
- The link to the contributing guidelines is dead
- "ensure CRDs are installed first" - no matches for kind "InitConfiguration" / "ClusterConfiguration" / "KubeProxyConfiguration"
- scheduler_extra_arguments not working on v1beta3 due to missing scheduler_merged_extra_arguments used in the template HOT 2
- Not able to generate certificates - undefined method `match' for nil:NilClass (NoMethodError) HOT 1
- Release new version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppetlabs-kubernetes.