Default structure doesn't inherit correctly about puppetlabs-kubernetes HOT 6 CLOSED

Ah, good to hear. I'm at a conference early this week, but I should be able to bang this out Thursday or Friday when I get back. The refactor is done, it's just the tests that need rewriting.

from puppetlabs-kubernetes.

@davejrt @scotty-c: I have a fix for my issues in the https://github.com/temujin9/puppetlabs-kubernetes/tree/neliot-fix-param-inheritance branch. However, this fix eliminates kubernetes::params (whose invocation order was causing the defaulting problem). Can you look at it, and tell me if that kind of fix is acceptable, and if not maybe suggest a different approach?

from puppetlabs-kubernetes.

I also trembled on this, my fix was to move the version var and the two depending to the main class, keeping the rest in the params

from puppetlabs-kubernetes.

@temujin9 I am happy to look at a PR that brings the data back into the module as is suggested in the best practices now.

from puppetlabs-kubernetes.

Ah, turns out my fix takes no correction at all. The test failures occur under the new default puppet version of 6.0.2, with or without my changes.

Setting PUPPET_GEM_VERSION="~> 5.5.7" makes test pass both before and after my change. I'll PR shortly, and then ticket this 6.0.2 issue (which is not a priority from our perspective).

from puppetlabs-kubernetes.

Actually, I notice that the most recent master is now pinned to 5.5.6, so I suspect you already know the issue. Let me know if you want me to ticket it.

from puppetlabs-kubernetes.