Giter VIP home page Giter VIP logo

Comments (3)

fmeeuw avatar fmeeuw commented on September 25, 2024 1

Hi @ruippeixotog,

I am sorry, a miscalculation on my part, I was assuming wrongly it was working before with 0.17.0 , but I checked all versions of pureconfig and uppercase never worked. So I guess this is not really an issue, more a design choice.
I guess we can close this.

from pureconfig.

ruippeixotog avatar ruippeixotog commented on September 25, 2024

Hi @fmeeuw! I have just tried reading an uppercase FALSE/TRUE string using v0.17.0 and it didn't work either:

❯ cat build.sbt
libraryDependencies += "com.github.pureconfig" %% "pureconfig" % "0.17.0"

❯ sbt console
scala> ConfigSource.string("b = FALSE").at("b").loadOrThrow[Boolean]
pureconfig.error.ConfigReaderException: Cannot convert configuration to a boolean. Failures are:
  at 'b':
    - (String: 1) Expected type BOOLEAN. Found STRING instead.

  at pureconfig.ConfigSource.loadOrThrow(ConfigSource.scala:81)
  at pureconfig.ConfigSource.loadOrThrow$(ConfigSource.scala:78)
  at pureconfig.ConfigSource$$anon$2.loadOrThrow(ConfigSource.scala:332)
  ... 31 elided

Can you point me out to an old PureConfig version that does this?

from pureconfig.

ruippeixotog avatar ruippeixotog commented on September 25, 2024

In this case it's not even PureConfig's design choice, we're following Typesafe Config's rules when it comes to converting config values to booleans, which itself follows the list of supported strings in the HOCON spec. PureConfig readers are often more powerful than Typesafe Config operations, but in this case I think it makes sense for us to stick with the HOCON spec. Nothing prevents you from writing your ConfigReader for this, of course 🙂

from pureconfig.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.