Missing separators after onPress toggling other cells about react-native-tableview-simple HOT 8 CLOSED

Just fixed my previous comment, looks like GitHub markdown was eating some of the < /> tags... hopefully it should make a bit more sense now! Basically it seems like <TouchableHighlight /> isn't firing off the onPressOut callback to un-highlight the row when you mess with the children of the <Section> presumably because somethings getting unmounted midpress? Not sure.

And I can definitely see the same issue on my iOS simulator, it's where I first noticed it. Let me try re-running that snack on my device though.

Edit: Yep, its still missing there.

from react-native-tableview-simple.

Good to hear!

Feel free to close this issue if it works for you now 👍

from react-native-tableview-simple.

Hi @philo23!

Glad that you like it!

That's an interesting issue. Could be something with this rows: https://github.com/Purii/react-native-tableview-simple/blob/master/src/components/Section.tsx#L128-L140

It may take some time before I can take a closer look. If you find a solution in the meantime feel free to open a PR 👍

from react-native-tableview-simple.

So I've done a little digging and it seems like highlightedRowIndex isn't getting reset back to undefined by unhighlightRow because the onPressOut callback isn't being fired from the <TouchableHighlight> used inside of the <Cell> component.

It's almost like <TouchableHighlight> is being unmounted or something before it gets a chance to call the onPressOut callback? but I'm not sure because that doesn't seem like it should work like that.

At first I thought it might be this line,

from react-native-tableview-simple.

Yep. Just saw that.
Happened on my rewrite to TS... but that's not released yet.

Tried to verify the issue with a local simulator. But there it works?

from react-native-tableview-simple.

Seems to be some kind of race condition.
For me it works with the Snack and locally...

Looks like component doesn't get rerendered if the children change.
The Touchable triggers an update of highlightedRowIndex which leads to a serenader of the Section. That's why it works after pressing the Touchable Component.

Section:127-132 controls the rendering of the Separator. Could you try out to debug the conditions?

Edit: Just released v3.0.0 with the TS Component. Best you update, so we have the same version.

from react-native-tableview-simple.

Great, I was just about to ask what the best way to try out the new TS version. I'll test out v3.0.0 now and let you know how it goes.

from react-native-tableview-simple.

I've updated it and it appears to be working now in-simulator, but I think the actual issue might have been that my react-native dependency was actually out of date by a couple of minor versions 😅

Weirdly the snack from earlier still seems to be broken even with the new v3 version... but I think this bug can probably be put down to something in React Native thats since been fixed!

from react-native-tableview-simple.