Comments (1)
Kind of confused why we're disecting the whole yml here: https://github.com/puzzle/ccli/blob/8ea35525c9/lib/serializers/ose_secret_serializer.rb#L9
We should just be able to do OSESecret.new(Psych.load(yaml)['metadata']['name'], yaml)
We're saving the whole yml to cryptopus anyways, so digging around in the yml and decoding stuff just seems.. unnecessary.
This would also mean that we don't have to encrypt anything anymore after pulling from cryptopus: https://github.com/puzzle/ccli/blob/8ea35525c9/lib/serializers/ose_secret_serializer.rb#L30
I'm not saying this fixes the issue. But it just feels so weird that I'm hoping that we can either actually identify or by chance kill the bug in the process.
from ccli.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ccli.