APK splash ratio / sharpness about cloudapk HOT 13 CLOSED

Hello peterpeterparker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

from cloudapk.

Hello peterpeterparker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

from cloudapk.

Hmmm @peterpeterparker , it should be using your 512x512 icon from your manifest https://github.com/pwa-builder/PWABuilder/blob/master/components/Download.vue#L97, is that icon blurry outside of the TWA?

from cloudapk.

@jgw96 the 512x512 isn't that really blurry.

source: https://deckdeckgo.com/assets/favicon/android-chrome-512x512.png

maybe some transformations are applied when the splash images are generated? or is it "just" a zooming question (the img on the splash of the pwa is smaller)?

from cloudapk.

I think what may be happening is that the 512x512 image is being stretched to generate an xxhdpi image, which would be 900x900px. An xxxhdpi would be even worse, as it's 1200x1200, but I think that is usually used on tabled devices - https://github.com/GoogleChromeLabs/bubblewrap/blob/master/packages/core/src/lib/TwaGenerator.ts#L58-L59

I'll check generation in Bubblewrap (https://github.com/GoogleChromeLabs/bubblewrap) and file the issue there. A solution would be not to generate stretched images and check how the browser will handle smaller images. If the browser stretches it, we may need to generate images with transparent space instead of stretching the icon.

from cloudapk.

Looking at the payload for generateSignedApk, it seems to be using the 192x192 image instead of 512x512. I checked out the Bubblewrap CLI, and it uses the 512x512 image.

{
    "packageId": "com.deckdeckgo.twa",
    "host": "deckdeckgo.com",
    "name": "DeckDeckGo",
    "themeColor": "#ffffff",
    "navigationColor": "#ffffff",
    "backgroundColor": "#ffffff",
    "startUrl": "/",
    "iconUrl": "https://deckdeckgo.com/assets/favicon/android-chrome-192x192.png",
    "maskableIconUrl": "https://deckdeckgo.com/assets/favicon/android-chrome-192x192.png",
    "appVersion": "1.0.0",
    "useBrowserOnChromeOS": true,
    "splashScreenFadeOutDuration": 300,
    "enableNotifications": false,
    "shortcuts": [],
    "signingInfo": {
        "fullName": "John Doe",
        "organization": "Contoso",
        "organizationalUnit": "Engineering Department",
        "countryCode": "US"
    }
}

Here's what the splash generated by the Bubblewrap CLI looks like:

from cloudapk.

@andreban ahh ok, interesting. So this is probably a logic issue on our side of things, ill take a look at this. Thanks Andre!

from cloudapk.

Update: Got a fix here pwa-builder/PWABuilder@e5532a0 for this issue. Working on the related issue #18 and then ill deploy.

from cloudapk.

Fixed as part of #18

from cloudapk.

The ratio works like a charm thx to your fix @jgw96 👍

from cloudapk.

from cloudapk.

Epic, thank you! Really appreciate you giving our service a try (:

from cloudapk.

My pleasure, it's really a great and handy service!

from cloudapk.