Comments (4)
That was the initial approach but ended up in a command explosion with dozens of commands. I prefer the current approach since it allows users to define their custom commands and alias.
from octo.nvim.
Hey, @pwntester sometimes it would be better to review a pr without checking it out
I will implement a review mode based on diffhunks only. It will not require checking out the PR or even have the repo locally. But it will miss the context provided by having the PR checkout.
or to have a single command to start review session
I can implement Octo review pr <repo> <number>
. But maybe cuatom mappings are enough
from octo.nvim.
I'm thinking Octo should have full command, I hate doing tab category tab action . What you think if I write commands like
OctoCreatePr
OctoCreateIssue
OctoReviewPr
In addition of OctoPr..., OctoIssue...
I think this is a bit a vim way, you can search them in command history easily
from octo.nvim.
Will close thisnone for now, thanks for the suggestion @tami5
from octo.nvim.
Related Issues (20)
- Utils `get_remote` doesn't work with `.ssh/config` aliases HOT 3
- Multiple github accounts can't connect HOT 7
- Trying to create a PR using `octo create pr [draft]` succeeds partially with error HOT 2
- Octo review start fails with large pull requests HOT 1
- [feature] make 'Octo comment add' work for visual HOT 2
- Feature - Respect PR template when creating a new PR. HOT 7
- Feature Request: go to next commit in review by commit mode
- BUG: Diff Highlight is lost in PR review when saving a comment HOT 2
- q
- Error when attempting to view review comments HOT 1
- Feature Request - add option for a unified diff view
- Filter "Only files owned by you" in pull request review flow
- Multiple PR comments created HOT 8
- Error hiding comment reaction popup with neovim 0.8 HOT 2
- Treesitter support for Markdown HOT 3
- [BUG] `:Octo repo list` fails HOT 1
- `Octo pr create` uses wrong branch
- Completion not working HOT 16
- Ability to sort issues/prs HOT 5
- [Bug] Viewing diff after adding a comment in PR review breaks and throw an error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octo.nvim.