Giter VIP home page Giter VIP logo

Comments (4)

pwntester avatar pwntester commented on August 15, 2024 1

That was the initial approach but ended up in a command explosion with dozens of commands. I prefer the current approach since it allows users to define their custom commands and alias.

from octo.nvim.

pwntester avatar pwntester commented on August 15, 2024

Hey, @pwntester sometimes it would be better to review a pr without checking it out

I will implement a review mode based on diffhunks only. It will not require checking out the PR or even have the repo locally. But it will miss the context provided by having the PR checkout.

or to have a single command to start review session

I can implement Octo review pr <repo> <number>. But maybe cuatom mappings are enough

from octo.nvim.

kkharji avatar kkharji commented on August 15, 2024

I'm thinking Octo should have full command, I hate doing tab category tab action . What you think if I write commands like 👍

OctoCreatePr
OctoCreateIssue
OctoReviewPr

In addition of OctoPr..., OctoIssue...

I think this is a bit a vim way, you can search them in command history easily

from octo.nvim.

pwntester avatar pwntester commented on August 15, 2024

Will close thisnone for now, thanks for the suggestion @tami5

from octo.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.