Giter VIP home page Giter VIP logo

Comments (2)

adam2392 avatar adam2392 commented on August 20, 2024

Here is a rendered doc that is a WIP of the PC algorithm API and its usage: https://output.circle-artifacts.com/output/job/4d057804-45d2-488b-89de-11fd8d37743c/artifacts/0/dev/index.html

This base class also defines the interface for any "constraint" causal discovery algorithm: https://github.com/py-why/dodiscover/blob/ab79e40853438ea6c5918554627b55a343c47ef2/dodiscover/constraint/_classes.py. Note this might change as Robert is updating the docs around Context vs data.

from dodiscover.

adam2392 avatar adam2392 commented on August 20, 2024

From the call, it seems the action items are:

  • implement a notebook/script that calls causal-learn and gets GES working on some example
  • write a function/class in dodiscover that wraps causal-learn's GES function and implements an api
  • add causal-learn to the pyproject.toml dev dependencies (I can help you do this)
  • write some unit/integration tests

There prolly will need to be some iterative discussion on the GES API. Basically, my general intuition is that all score-based algorithms should subclass a base class, or have a standard function signature.

Some thoughts on GES wrapping causal-learn

causal-learn docs contains the parametrization of GES in causal-learn. Note the differences relative to what dodiscover does.

  1. data is a numpy array rather than dataframe
  2. parameters imo should be "snake cased", like 'max_parents' instead of 'maxP'
  3. score function: should it be a Callable object, or str? If callable, then what is the expected signature of any score function? For example, see sklearn's metrics, which all have a standard function signature of y_true, y_pred, *, normalize=True, sample_weight=None.

By standardizing the interface that all score-based algorithms are called in dodiscover, we'll greatly simplify user life and future algorithms. Lmk if I missed anything?

from dodiscover.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.