Giter VIP home page Giter VIP logo

Comments (6)

amit-sharma avatar amit-sharma commented on July 23, 2024 1

That's a great idea @drawlinson . Yeah, it is better to remove use of get_dummies. Look forward to your PR

from dowhy.

drawlinson avatar drawlinson commented on July 23, 2024

PR here #1112

from dowhy.

drawlinson avatar drawlinson commented on July 23, 2024

I think this is resolve with merge of PR 1112 . However, its also an option to remove use of get_dummies entirely if this is considered desirable, using the same util function to replace each occurrence. I can make another PR to complete that process. Keen for thoughts on that... there would be some simplification by pushing encoders down to the base CausalEstimator and things would be more consistent between estimators.

from dowhy.

drawlinson avatar drawlinson commented on July 23, 2024

I'll get onto that ASAP!

from dowhy.

drawlinson avatar drawlinson commented on July 23, 2024

@amit-sharma PR now available to complete the job... #1135

from dowhy.

drawlinson avatar drawlinson commented on July 23, 2024

Resolved with PR #1135

from dowhy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.