Giter VIP home page Giter VIP logo

Comments (7)

pyasi avatar pyasi commented on July 18, 2024 1

I totally agree with you! No aspersions received =). If you'd like to submit a patch I'd be happy to accept. It will be a day or two before I'm freed up to handle the pip packaging but I will!

from pybuildkite.

GMNGeoffrey avatar GMNGeoffrey commented on July 18, 2024

@pyasi are you still actively maintaining this repo? It looks like there hasn't really been any activity since last fall.

from pybuildkite.

pyasi avatar pyasi commented on July 18, 2024

@GMNGeoffrey Yes, there has not been much activity lately but I am interested in continuing to maintain this. I agree that given the frequency of changes to the Buildkite API that kwargs is likely a better long term decision.

from pybuildkite.

GMNGeoffrey avatar GMNGeoffrey commented on July 18, 2024

Great! I'm happy to send a patch if you can deal with releasing a new pip package :-)

from pybuildkite.

GMNGeoffrey avatar GMNGeoffrey commented on July 18, 2024

Didn't mean to cast aspersions wrt "lack of activity". In my opinion minimal-maintenance things are generally much better than things where the developer pretends that they're actually going to stay on top of everything forever :-D

from pybuildkite.

mwgamble avatar mwgamble commented on July 18, 2024

#82 was just merged, which goes part of the way to solving this problem.

My personal opinion is that they shouldn't be replaced by a general kwargs argument. One of the most important reasons to use an API client like this over using requests.post() directly is type-safety. I would much rather see individual options added as necessary, so that I can more easily verify my own code is doing the right thing.

from pybuildkite.

mwgamble avatar mwgamble commented on July 18, 2024

(it would be great if a new release could be created that includes #82)

from pybuildkite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.