Don't remove imports from __init__.py about autoflake HOT 6 CLOSED

Just a note, as I was having a similar issue and came here before but didn't find this info.

You can exclude a single line adding a comment # noqa, like:

from .endpoints import role, token, user, utils  # noqa

I also submitted a PR adding that to the docs: #43

from autoflake.

I think having such an option makes sense. It might be useful to get some metrics on how common this is. That would help us get an idea on whether this new behavior should be an option or the default.

Currently, autoflake can only exclude __init__.py files via --exclude=__init__.py. But that will make autoflake completely ignore it. And --exclude is only relevant to recursive mode.

from autoflake.

It's pretty standard: e.g., https://github.com/numpy/numpy/blob/master/numpy/linalg/__init__.py

It's better to do it this way than to explicitly list things in the __init__.py otherwise changes to exported names have to be done in two places (__all__ in the module, and the import statement in __init__.py).

Also, I don't think it should be an option, or at least the option should default to true. Things imported by __init__.py are for the importer of that package—not for code within __init__.py.

from autoflake.

I agree, about the option setting. It makes sense to by default be conservative and not remove things. I'll accept a pull request to make such a change. Otherwise, I'll take a look in a few months when I'm less busy. Thanks!

from autoflake.

Thanks!

from autoflake.

Working on this issue, may I be assigned to it? Thanks!

from autoflake.