a ‘pass’ statement in an intentionally empty function with a docstring is not useless about autoflake HOT 6 CLOSED

I just came across this tool and was very exited. But this is a showstopper.

Can you make it configurable to remove 'useless' pass statements or not? If I run autoflake with --remove-all-unused-imports I expect to not make any other changes except to the imports.

from autoflake.

This also happens if you use methods decorated with @abc.abstractmethod: they will typically have a docstring but no implementation.

from autoflake.

... reads as a placeholder for code that needs to be written, or that it's a ‘template’ ‘blueprint’, e.g. in .pyi stub files.

pass in an exception class body means it's intentionally empty. another use case is the click example and its rationale in my earlier comment.

from autoflake.

Sometimes people use ellipsis ... in empty functions to mark it as implementation missing, though not sure is that more of a hack, as it has varying semantics depending on where it's used.

Still, I actually prefer using ellipsis in these cases, as it stands out more clear that method/function doesn't have implementation, and autoflake doesn't seem to complain about it either.

from autoflake.

Good explanation, thanks!

from autoflake.

Will this be fixed?

from autoflake.