Handle multiline import-from statements about autoflake HOT 5 CLOSED

There exists a possible workaround in combination with isort:

• Reformat every import into one line: isort -rc -sl .
• Use autoflake to remove unused imports
• Reformat the imports the way you want them to be using isort -rc -m x . (x being one of the different multi-line modes isort offers for imports)

from autoflake.

Just adding here that autoflake is also unable to detect single-line imports with parentheses:

from re import sub
from re import (subn)

First line is detected, second one is not. This will surely be fixed by a fix of this issue, but until then, maybe (just maybe) it makes sense to tackle it independently in the meantime.

from autoflake.

If I recall, for simplicity, autoflake just ignores cases where parentheses are used for imports. Pull requests to support this case are welcome.

from autoflake.

>>> autoflake.fix_code("from moduele import a, b\na.abc = 1\n", remove_all_unused_imports=True)  
'from moduele import a\na.abc = 1\n'                                                             
                                                                                                 
>>> autoflake.fix_code("from moduele import (a, b)\na.abc = 1\n", remove_all_unused_imports=True)
'from moduele import (a, b)\na.abc = 1\n'                                                        

I took a look at the source. The parser/autflake handles a sinle line at a time. So it doesn't suppor muli-line structures :(

from autoflake.

There exists a possible workaround in combination with isort:

• Reformat every import into one line: isort -rc -sl .
• Use autoflake to remove unused imports
• Reformat the imports the way you want them to be using isort -rc -m x . (x being one of the different multi-line modes isort offers for imports

This workaround works great in most cases but fails in one, when I have to use it together with git precommit hooks:

$ git commit

isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /projects/hooks/builder.py

autoflake................................................................Passed
isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /projects/hooks/builder.py

This happens because even files formatted correctly are updated by first run of isort. As a result even correctly formatted files will not be commited.

from autoflake.