Comments (7)
Potentially. I'm actually working on it right now, so I'll also check this.
from flake8-bugbear.
this creates a new object that no longer depends on the original
That's not true in Python 3. Your code will throw RuntimeError: dictionary changed size during iteration
.
from flake8-bugbear.
Same issue here:
https://github.com/Project-MONAI/MONAI/actions/runs/8777993558/job/24083761562#step:2:2647
from flake8-bugbear.
Thanks for tagging me!
I'll take a look later this week and see if I can fix it right away, or if it blows up the scope (I doubt the latter one). 🙂
from flake8-bugbear.
Hi,
we're seeing complaints for code like
lst: list[dict] = [dic1, ..., dicn]
for dic in lst:
dic["key"] = False
Is this related?
from flake8-bugbear.
I've created #469 - the fix was rather easy and simple, just an oversight in the initial implementation 😬
I've ran it on the black code base with the only hit being ./black/src/blib2to3/pgen2/pgen.py:235:21
, which is a true positive considering the comment in line 223 (for state in states: # NB states grows while we're iterating
).
With Project-MONAI, I could also eliminate the cases pointed out, however, there is a discussion point (hence the PR only being a draft):
Should B909 allow altering an element via it's dictionary key? For example:
some_dict = {...}
for key in some_dict:
some_dict[key] = 3
del some_dict[key]
Should this fire B909 or not? What do you think?
cc @cooperlees
from flake8-bugbear.
Should B909 allow altering an element via it's dictionary key? For example:
some_dict = {...} for key in some_dict: some_dict[key] = 3 del some_dict[key]
I'd argue it should fire due to the del
.
EDIT: The following is incorrect and shouldn't be considered - I leave it here for completeness as it was partially quoted:
However, I'd also argue it shouldn't in such a case:
some_dict = {...}
for key in some_dict.keys(): # this creates a new object that no longer depends on the original
some_dict[key] = 3
del some_dict[key]
from flake8-bugbear.
Related Issues (20)
- Policy on bugbears in usage of popular third party libraries HOT 2
- B026 False negative on class methods HOT 1
- B017: False negative when "from" imports used HOT 2
- Improve unit test runner HOT 2
- Feature request: a rule for calling super().__init__() in custom exception's __init__() HOT 2
- Feature request: a rule for detecting calls to mutate all-caps "constants" HOT 1
- B035: False positive for comprehensions that use a walrus operator
- Couple new rule suggestions HOT 2
- Rule to detect changes to iterable object of loop HOT 5
- Error in latest version of flake8-bugbear 24.1.15 HOT 4
- B038 false positive in 24.1.15 + 24.1.16 HOT 5
- B018 doesn't trigger for useless expressions involving multiple variables HOT 3
- B909 improvements HOT 4
- B038 false positives HOT 5
- How to handle B015 within pytest.raises blocks
- B031 does not take into account if-else statements
- B023: false positive for nested function inside loop HOT 1
- B024 false negative when there's a class var
- Incorrect version number 24.4.6? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flake8-bugbear.