Custom serializer discarded when WrapSerializer is used about pydantic HOT 4 OPEN

At first glance I don't think it's a bug per se but maybe more like a limitation of what you can achieve with these annotations.

from pydantic.

Looks like the current behavior is such that the custom get schema function overrides any changes applied via annotations.

you got that backwards: the annotation is overriding the custom serializer of the type.

From an implementation point-of-view, I get why you'd think this is more a limitation than a bug, since the workaround for a user is pretty straightforward. However, I'd definitely argue that this is conceptually a bug. Also, it can be very disorientating for a user using a custom type from a 3rd-party library: here the user would likely not be aware beforehand that the custom type is using a custom serializer method, and would annotate it all the same in their code, at which point they would be confused as to why their WrapSerializer doesn't actually wrap the expected serialization.

from pydantic.

@ornariece,

Hmm, thanks for reporting this. I don't think this is necessarily a bug, but perhaps a change request. Looks like the current behavior is such that the custom get schema function overrides any changes applied via annotations.

@adriangb, is this intentional? Is this something we want to change?

from pydantic.

you got that backwards: the annotation is overriding the custom serializer of the type.

Ah yes, you're right. This seems like a bug!

from pydantic.