Comments (12)
+1
Only one thing, I don't think it should be necessarily at the same time. To say, can also already release a 0.1 now (or in some weeks if there are still some bug reports people are working on. Certainly if some people already want to start working on new features, like the requests from @femtotrader). And then just say when pandas releases that what is in pandas is equivalent with pandas-datareader 0.1
from pandas-datareader.
right. I just want to be sure there is a version of pandas-datareader
that is completely the same as what 0.16.0 will release.
from pandas-datareader.
@jreback Sure, I'll do that.
from pandas-datareader.
I was able to check the diff
of the files (web.py and data.py) against the respective files in pandas, and this diff should just be imports (IIRC). Worked a treat. (Same thing for the test files.)
from pandas-datareader.
I've marked the commit that was the same as pandas v0.16.0 as v0.1.0.
A couple questions:
- Should we announce this anywhere?
- Should we keep pandas.io.data in-sync from this point forward?
from pandas-datareader.
As I've said before, I think we should make pandas-datareader a soft dependancy of pandas. and change the pandas/io/data.py
to from pandas_datareader import data
, etc, this will keep it insync when the user updates pandas-datareader. This should be post 0.16.final
. datareader tests should remain in pandas for the foreseeable.
(It would also help to do the same with pandas-compat... otherwise we can just copy it into pandas_datareader, since that's the thing which breaks pandas-datareader on 0.12-... compat is a part of the pandas codebase that is both useful and stable.)
Not sure if this was agreed on in pandas-dev/pandas#8961 ??
from pandas-datareader.
I agree with @hayd here; We will schedule this for 0.17.0. In the meantime, I think pandas-datareader
can move at its own pace. The only thing I would ask is if you need/want to change the API, then we would recommend the compat version (for 0.17.0) at least.
@dstephens99 as far as releases go.
I would:
- send out an announcement, here is the pandas release checklist, which is much more complex because of all of the extensions and platform dependencies. pandas-datareader is straightforward in that its a python only package
- upload to pypi
- docs; prob consider moving to
readthedocs
, its really easy, and builds on pushes from github (it DOES work with non-built dependencies, e.g. you can use numpy/pandas etc for it).
from pandas-datareader.
Usual pandas rules then: extend the api (for great good) but don't break it.
Can we add to the checklist: add the rc-release to pandas-datareader's .travis.yml (to trigger the tests)... Is an RC available via conda??? #5
from pandas-datareader.
conda should be up soon
from pandas-datareader.
about the docs, I had a PR starting with that, I will try to finish that this weekend, unless someone beats me to it
from pandas-datareader.
Started a release checklist for pandas-datareader here (based on the pandas one).
https://github.com/pydata/pandas-datareader/wiki/Release-Checklist
Added @hayd 's comment on adding rc-release to .travis.yml
from pandas-datareader.
To clarify, my comment was for during the pandas release cycle (e.g. when 0.17.0rc comes out, check that build passes the pandas-datareader tests - e.g. test locally and add the newer version of pandas to pandas-datareader's .travis.yml).
I think the release checklist for pandas-datareader can be a lot shorter than pandas! :) e.g. No need for release candidates... "fixed some bugs -> ship a release"... ?
One thing I would say to check backwards compat, is that you can run the old tests from pandas:
from pandas.io.tests import test_data
# nose.runmodule(test_data) # not the right syntax, but I recall doing this in the past..
....This is probably doomed to failure (due e.g. to numbers changing).
from pandas-datareader.
Related Issues (20)
- requests.exceptions.SSLError: HTTPSConnectionPool(host='stats.oecd.org', port=443): Max retries exceeded with url: /SDMX-JSON/data/PRICES_CPI/all/all (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:997)')))
- Line 234 of tiingo.py needs to be updated according to new pandas update HOT 2
- 'DataFrame' object has no attribute 'append' HOT 4
- AttributeError: module 'configparser' has no attribute 'SafeConfigParser' HOT 14
- get_nasdaq_symbols() is failing today. API endpoint problem? HOT 6
- get_sector_performance_av returning Meta Data HOT 1
- FutureWarning: The argument 'date_parser' is deprecated and will be removed in a future version. Please use 'date_format' instead, or read your data in as 'object' dtype and then call 'to_datetime' HOT 2
- ImportError: cannot import name 'reduce' from 'pandas_datareader.compat' when using pandas_datareader.wb HOT 1
- TypeError when indexing response from DataReader with 'yahoo' as data source HOT 1
- Future release(s) of pandas-datareader HOT 2
- AttributeError: module 'configparser' has no attribute 'SafeConfigParser' HOT 2
- Actualize docs after setup modernization
- web.DataReader + "fred": Failed Downloads
- TypeError HOT 1
- TypeError: string indices must be integers, not 'str' HOT 1
- STDERR is used instead of an exception HOT 1
- PyPi Long Description Content Type is incorrect
- MOEX: AttributeError: 'DataFrame' object has no attribute 'append' HOT 1
- ModuleNotFoundError: No module named 'distutils' after importing pandas-datareader HOT 1
- OECDReader: Unable to read URL
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pandas-datareader.