Giter VIP home page Giter VIP logo

Comments (5)

medariox avatar medariox commented on May 24, 2024 1

I think the best solution is to add a domain whitelist for the webhook requests. I will get to it when I have some time or maybe someone else can pick this up and submit a PR.

from medusa.

medariox avatar medariox commented on May 24, 2024

What does the webhook URL look like (remove the sensitive parts)?

from medusa.

LeeThompson avatar LeeThompson commented on May 24, 2024

I've randomized the sensitive bits. NOTE: I've tried with and without a trailing /

http://rocketchat.abc.defg.hij:3000/hooks/56305c4ab173e84efb916e6c/jRpTnrtGnBErdTmbkMwMbbyoSMknGiy4JyqcSxWBR373Z2R4

from medusa.

medariox avatar medariox commented on May 24, 2024

Webhook URLs need to be validated for security reasons, see: #11565
What is the Webhook pattern we need to support for Rocketchat?

from medusa.

LeeThompson avatar LeeThompson commented on May 24, 2024

(from the PR) WEBHOOK_PATTERN = r'https://hooks\.slack\.com/services/.*'
This definitely isn't going to work with RocketChat since it can be self-hosted (as it is in my case) so it will never be on slack.com

I'm not familiar with the Python RegEx syntax but it's basically http or https:// with a host.domain (with optional port) and then /hooks/' and the token which is generated, here is one I generated for an example (it's a real one that I'm deleting right away) 65e1f75c00ab53363395d0aa/2yXaxN6k566kPLAvmsKxeSE4L6mxLfzgi6GKovaSC2kE7GJk`

https://rocketchat.domain/hooks/65e1f75c00ab53363395d0aa/2yXaxN6k566kPLAvmsKxeSE4L6mxLfzgi6GKovaSC2kE7GJk
http://rocketchat.domain:port/hooks/65e1f75c00ab53363395d0aa/2yXaxN6k566kPLAvmsKxeSE4L6mxLfzgi6GKovaSC2kE7GJk

Docs on RocketChat integrations, message syntax can be identical to Slack's but it also supports additional features.
https://docs.rocket.chat/use-rocket.chat/workspace-administration/integrations

from medusa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.