🐛 Bug When running in a Service Worker, <code class="notranslate"

Thanks for the report <a class="user-mention notranslate" data-hovercard-type="user" d

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

`open_url` returns an empty `StringIO` object when run inside Service Worker about pyodide HOT 3 OPEN

ibdafna commented on June 12, 2024

`open_url` returns an empty `StringIO` object when run inside Service Worker

from pyodide.

Comments (3)

ryanking13 commented on June 12, 2024

Thanks for the report @ibdafna. pyodide.http.open_url relies on XMLHttpRequest and AFAIK XMLHttpRequest is not supported in the service worker.

from pyodide.

ibdafna commented on June 12, 2024

Hi @ryanking13, thanks for taking a look. Whilst you're technically correct about XHR not being supported in Service Workers, there is a polyfill called xhr-shim (I mention that in the initial post), and the official Pyodide documentation advises installing that polyfill as a precondition for using Pyodide in a Service Worker. The polyfill does seem to work outside the context of Pyodide, so I'm inclined to believe there's an issue somewhere else.

from pyodide.

ryanking13 commented on June 12, 2024

Oh, sorry I didn't read your post closely enough.

Could you try using XMLHttpRequest directly instead of using open_url and compare the response (content, status code, headers) when running it in main thread without xhr-shim and in the service worker?

You can see the implementation of open_url here:

pyodide/src/py/pyodide/http.py

Lines 27 to 46 in 3bf1075

 def open_url(url: str) -> StringIO: 

 """Fetches a given URL synchronously. 

  The download of binary files is not supported. To download binary 

  files use :func:`pyodide.http.pyfetch` which is asynchronous. 

  Parameters 

  ---------- 

  url : 

  URL to fetch 

  Returns 

  ------- 

  The contents of the URL. 

  """ 

 req = XMLHttpRequest.new() 

 req.open("GET", url, False) 

 req.send() 

 return StringIO(req.response)

from pyodide.

Recommend Projects

`open_url` returns an empty `StringIO` object when run inside Service Worker about pyodide HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	def open_url(url: str) -> StringIO:
	"""Fetches a given URL synchronously.

	The download of binary files is not supported. To download binary
	files use :func:`pyodide.http.pyfetch` which is asynchronous.

	Parameters
	----------
	url :
	URL to fetch

	Returns
	-------
	The contents of the URL.
	"""

	req = XMLHttpRequest.new()
	req.open("GET", url, False)
	req.send()
	return StringIO(req.response)