"ERROR: build script failed" but "Succeeded building package" about pyodide HOT 5 CLOSED

I think it needs to re-raise in the SystemExit case too

from pyodide.

Thanks for the report. I think this bug has been present for the full three years I've been a maintainer of Pyodide and nobody has ever gotten around to fixing it... It is a bit confusing though.

from pyodide.

Any hint where to start to look to fix it?

from pyodide.

Looks to me that the problem is here:
https://github.com/pyodide/pyodide/blob/main/pyodide-build/pyodide_build/buildpkg.py?plain=1#L863-L873

    success = True
    try:
        _build_package_inner(...)
    except Exception:
        success = False
        raise
    finally:
        status = "Succeeded" if success else "Failed"

success is being left as True so the generic exception handler is not being executed. The ERROR message is printed here:
https://github.com/pyodide/pyodide/blob/main/pyodide-build/pyodide_build/buildpkg.py?plain=1#L124-L126

            logger.error(f"ERROR: {script_name} failed")
            logger.error(textwrap.indent(cmd, "    "))
            exit_with_stdio(result)

And exit_with_stdio raises SystemExit which is not caught by except Exception. So we should add handling for KeyboardInterrupt and SystemExit on line 863. I think the following patch would probably be sufficient:

--- a/pyodide-build/pyodide_build/buildpkg.py
+++ b/pyodide-build/pyodide_build/buildpkg.py
@@ -860,9 +860,11 @@ def build_package(
             continue_=continue_,
         )
 
-    except Exception:
+    except (Exception, KeyboardInterrupt):
         success = False
         raise
+    except SystemExit as e:
+        success = e.code == 0
     finally:
         t1 = datetime.now()
         datestamp = "[{}]".format(t1.strftime("%Y-%m-%d %H:%M:%S"))

Though we might consider adding a distinct message for KeyboardInterrupt and I'm not sure that anyone ever raises SystemExit(0) so it's not clear how important that case is.

from pyodide.

I've put a working version in #4404

from pyodide.