[v0.2] Permission error with Cutout.prepare() on Windows. about atlite HOT 3 CLOSED

Ah ok, it's clear why that happens. Windows puts locks on all open files, so that one cannot delete or actually even read from an already open file and i'm trying to delete the temporary files seemingly at a point in time, when the libnetcdf library used by xarray hasn't released them just yet. Instead i will have to schedule deletion somehow and then only execute them a tiny bit later. Will not affect linux or macos as they don't use these locks.

Will have to experiment a bit.

from atlite.

Update on tracking down the problem:

The PermissionError pops up at this point, where merging of the different feature datasets happens:

https://github.com/FRESNA/atlite/blob/6f3559d5e20a05c79fa55596623c732930581178/atlite/data.py#L163

Then the weakref.finalize(...) is triggered calling the unlink. At first I thought that was too early, but then I figured we just have to close the xarray.Dataset properly... .
I'll create a PR in a moment.

from atlite.

the whole point of the finalizer was to delete the file automatically after xarray itself decides it's time to close the file. So closing it yourself kind of defeats the purpose (even if it works in this particular case). I dug a bit deeper into xarrays code and found that it is always using a (Caching)FileManager to handle cleaning up of open files, and thus moved the finalizer there. So that as soon as the filemanager handling the file is garbage collected the finalizer is called and deletes the file. I just pushed the code (f3ab9b0). It works fine in a Win7 virtualbox for me.

from atlite.