Giter VIP home page Giter VIP logo

Comments (4)

endrebak avatar endrebak commented on July 30, 2024

I agree with all, but I'll leave 2) as an exercise for someone else since it is a lot of work for what is likely to be a surprisingly small gain in speed (try it yourself with read_full vs read_sparse to see).

I already support using flags. See here: https://github.com/pyranges/bamread/blob/master/bamread/src/bamread.pyx#L17

from bamread.

endrebak avatar endrebak commented on July 30, 2024

I should also support writing bams, but I use bams ever so seldom that I've never gotten around to it (and I am not completely sure how to do it either).

from bamread.

endrebak avatar endrebak commented on July 30, 2024

The current functions contain some extra stuff to make sure the data is valid for pyranges like

if start < 0 or end < 0: continue

I guess I should create new similar ones to use for the standalone library so that it acts completely like pysam.

from bamread.

endrebak avatar endrebak commented on July 30, 2024

(Just writing notes to self here)

I guess we can alias read_bam to read_sam in __init__.py since I do not think pysam cares about the distinction.

read_sam = read_bam

Worst case we need to change this to not be binary I think: samfile = pysam.AlignmentFile(filename, "rb")

from bamread.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.