Comments (3)
I would recommend providing two stable Docker images (for pyRDDLGym v1 and v2) via Docker Hub. This guarantees that the images will work and saves users the time-consuming build process.
For this we have to keep in mind:
- pyRDDLGym only produces correct Prost logs from version >= 1.4.3. See pyrddlgym-project/pyRDDLGym#240. Additionally pyrddlgym-project/pyRDDLGym#248 must be fixed for pyRDDLGym 1.x
- Is the issue pyrddlgym-project/pyRDDLGym#238 for any pyRDDLGym 1.x fixed?
- pyRDDLGym 2.0 produced an IndexError. Therefore version > 2.0 will be stable.
It would probably be best to add this information as a warning
to prevent users from building Docker images with pyRDDLGym versions that have known issues.
from pyrddlgym-prost.
Hi,
Thanks for your feedback about it. I agree with most points, especially about hosting a docker image on Hub.
The issues mentioned are fixed in 2.0, but not yet in 1.4. The pyrddlgym-project/pyRDDLGym#238 is only partially fixed, since there may still be boundary cases that are not handled in the fix (but it should work for all of the typical cases and existing domains that exist). I think it's mainly a matter of backporting all these fixes into 1.4.4.
We need to decide whether its worth doing all this and changing 1.4.4 in order to support 1.x in the Prost. Functionally, I do not see any point myself because the user does not interact with the pyRDDLGym server in any way with the current setup when running the docker images. For consistency, there is also no longer support for 1.4 and all of the other baselines, and likely will not be.
from pyrddlgym-prost.
I agree, that supporting pyRDDLGym 1.x wouldn't bring any benefits as the (Prost) results will be the same.
With
pyRDDLGym 2.0 produced an pyrddlgym-project/pyRDDLGym#248. Therefore version > 2.0 will be stable.
I meant the released package. But since the Dockerfile always pulls the latest pyRDDLGym version from Github, you're right, the problem is fixed.
from pyrddlgym-prost.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyrddlgym-prost.