Giter VIP home page Giter VIP logo

Comments (6)

pyroscope avatar pyroscope commented on May 24, 2024 2

I don't see in what way a Makefile help in adoption, especially since rT-PS is not "distro-compatible" by design (rpath-linking fits no normal distro).

For example, if you wanted to make a "real" Debian package of this, you'd have to put the patches into quilt and get rtorrent/libtorrent as orig tarballs. But I care more for working and stable than policy-conforming.

from rtorrent-ps.

GuillaumeSeren avatar GuillaumeSeren commented on May 24, 2024 1

@pyroscope
i understand your point but as a user I think it is not really easy,
to install it that way, except the case you covered the install process is specific.

I am still trying to find the best way to get it on Gentoo, if you have any pointers let me know !

from rtorrent-ps.

pyroscope avatar pyroscope commented on May 24, 2024

Because bash is just as portable as makefiles, especially when they contain… shell commands. Make is for optimizing dependencies, and there are none here.

The build is as it is, and I only directly care for Debian. Anything else must come from people running other stuff.

Use "build.sh install" for an /opt install (which is explained in the readme).

from rtorrent-ps.

GuillaumeSeren avatar GuillaumeSeren commented on May 24, 2024

Hey @pyroscope
thank you for quick-reply.

Because bash is just as portable as makefiles, especially when they contain… shell commands. Make is for optimizing dependencies, and there are none here.

I understand you POV, that's just Makefile are a standard for building project and shell script not (despite my love for shell script), plus using a more 'standard' way to build your project can really help to distribute it across distros, and give you more users.

The build is as it is, and I only directly care for Debian. Anything else must come from people running other stuff.

Reading the build.sh script I understand you made it for debian first, that's why I asked if you are interested in making a Makefile, which you still can call with your script if you want, but it should really help distro packagers.

from rtorrent-ps.

WindfallProphet avatar WindfallProphet commented on May 24, 2024

@GuillaumeSeren
I'm wondering if docker would work. No idea, but it's worth a try!

from rtorrent-ps.

GuillaumeSeren avatar GuillaumeSeren commented on May 24, 2024

@WindfallProphet Yes but it would be a bit overkill, instead of just compiling it.

I understand the point of the author, it would require more work to make it generic.

from rtorrent-ps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.