Giter VIP home page Giter VIP logo

Comments (7)

pyrossh avatar pyrossh commented on August 18, 2024 1

Thats a nice idea. We can get the latest MSRV based of the deps. Maybe need to figure what version will suffice all features.

from rust-embed.

osiewicz avatar osiewicz commented on August 18, 2024 1

There's cargo-msrv we could use for that I guess

from rust-embed.

pyrossh avatar pyrossh commented on August 18, 2024 1

Tested it. It seems MSRV is v1.60.0.

from rust-embed.

pyrossh avatar pyrossh commented on August 18, 2024 1

Yeah I think so. Couldn't find a way to run it with all the features enabled. So my assumption is thats what it does.

from rust-embed.

pyrossh avatar pyrossh commented on August 18, 2024

I was thinking MSRV would be based on the latest edition supported. Right now the project is using Rust 2018 edition. We might need to upgrade it to 2021. Then I think MSRV would be Rust v1.56.0.

from rust-embed.

osiewicz avatar osiewicz commented on August 18, 2024

1.56 does not work for rust-embed itself (there are dependency errors around bstr/axum for whatever reason) and while 1.60 works for just rust-embed, it fails with compression feature enabled. Seems like MSRV of include-flate is 1.63 at the very least.

Either way, the linked PR does not break MSRV. Thanks!

from rust-embed.

osiewicz avatar osiewicz commented on August 18, 2024

Cool. That's just for rust-embed without compression feature though, right?

from rust-embed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.