Turn warnings into errors in the test suite about pluggy HOT 5 CLOSED

@nicoddemus yeah test_call_with_too_few_args is obviously an intentional case but the first two can probably just be fixed.

We can error on warnings with pytest setting yah?

from pluggy.

Yep, just configure it on pytest.ini:

[pytest]
filterwarnings =
    error

from pluggy.

Hit the first problem:

DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec()

For py2 we need inspect.getargspec() but on py3 we're supposed to use inspect.signature (3.5+) or inspect.getfullargspec (3 < py < 3.5).

Doing a quick search the dual compatibility fix looks something this.

I think we'll need a separate issue for that.

from pluggy.

i wonder if it would work to just go for funcsigs2 on python2 (its a backport)

from pluggy.

If that works I would rather that than cook something up.

from pluggy.