Comments (19)
Here's the list of contributors:
- @fogo
- @jurko-gospodnetic
- @asfaltboy
- @tigarmo
- @satyrius
- @Chronial
- @The-Compiler
- @rouge8
- @jespino
- @RonnyPfannschmidt
- @jayvdb
- @blueyed
- @marcwebbie
Guys does any of don't agree to change pytest-mock
license from GPL3 to MIT in the next release?
from pytest-mock.
On May 24, 2016 06:39, "Tony Narlock" [email protected] wrote:
I can't use any form of GPL at work (including LGPL). Even if it was
possible, the handling considerations wouldn't be worth it for a plugin. A
few months ago I had a remote worker try to borrow code from an LGPL plugin
for a project, thinking "hey it's open source, and freedom". Its not easy
to convey the ramification of creating a derivative work.pytest itself is MIT.
This only matters if you want to distribute your library and it is packaged
with the plugin, is it your case?
Oliver
from pytest-mock.
Note this would probably also require the consent of all contributors as far as I know - while that's probably doable with 13 people, it's still somewhat of a hassle.
from pytest-mock.
Myself in my newest projects have followed pytest's example and use MIT, so personally I wouldn't mind. But @The-Compiler is right of course, we should ask consent for all contributors. Perhaps a poll on this thread is enough to obtain consent from everyone? What do you guys think?
from pytest-mock.
I think the quotation of the email above is broken.
This only matters if you want to distribute your library and it is packaged
with the plugin, is it your case?
I could go expound on this if you like. I think the onus should rest upon the one backing the more sophisticated license to justify it. GPL is not backward compatible unfortunately.
Note this would probably also require the consent of all contributors as far as I know - while that's probably doable with 13 people, it's still somewhat of a hassle.
I think the earlier its done the better. As a stop-gap, you can also add to the README that after 68f7968 (for example) all future commits are licensed MIT.
from pytest-mock.
@nicoddemus As far as I know, other projects handled this by mentioning all people in an issue (like this one) and asking them to respond if they agree with adopting the new license. Should I do so?
@tony With all due respect, if you want to change the license of a project people work on in their free time, it's your job to explain the rationale behind doing so, and not the other way around. π
FWIW to tick that one off, I'm okay with relicensing my contribution (deleting a file, heh) under the MIT license.
from pytest-mock.
As far as I know, other projects handled this by mentioning all people in an issue (like this one) and asking them to respond if they agree with adopting the new license.
That's exactly what I had in mind, sorry for not being clearer. π
Should I do so?
Yes, thanks! I was planning on doing this tonight, but if you got some minutes to spare I would appreciate it. π
from pytest-mock.
project people work on in their free time,
I think the biggest piece of gratitude you can get (other than money) is that someone using your software. I spent the past few days converting projects from unittest to py.test and apparently am quite happy prompt-toolkit/pyvim#35 (comment)
With all due respect, if you want to change the license of a project people work on in their free time, it's your job to explain the rationale behind doing so, and not the other way around. π
I offered to elaborate. π
I have before: ScottDuckworth/python-anyvcs#32, urwid/urwid#41, django-wiki/django-wiki#454, ycm-core/ycmd#139, pypa/pip#3441, jgm/peg-markdown#35, saitoha/canossa#1
Various outcomes.
from pytest-mock.
Thanks for the links, interesting reading. π
from pytest-mock.
Fine by me.
from pytest-mock.
My contribution in this project is really small (a typo fix), so of course, I agree with the change π
from pytest-mock.
You have my permission too, of course!
Tiago
On Wed, May 25, 2016 at 2:34 AM, JesΓΊs Espino [email protected]
wrote:
My contribution in this project is really small (a typo fix), so of
course, I agree with the change πβ
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#45 (comment)
from pytest-mock.
MIT license, here we go!
from pytest-mock.
fine by me
from pytest-mock.
Fine by me!
from pytest-mock.
me too, no problemo
from pytest-mock.
OK, thanks everyone!
I will change pytest-mock
license to MIT in the 1.1 release, making sure to mention that prominently on the CHANGELOG.
from pytest-mock.
I'd recommend changing the license in the repo ASAP, to make sure new contributors are aware of what license they're licensing their contributions under (in case there should be new people between now and 1.1).
from pytest-mock.
Oh thanks, good point, I will do that later.
from pytest-mock.
Related Issues (20)
- mocker.patch does not change return value HOT 3
- missing 1 required positional argument: 'mocker' HOT 3
- assert_called_once_with calls __eq__ multiple times HOT 3
- sdist is missing tox.ini HOT 1
- Spying on pydantic objects HOT 1
- Changelog broken HOT 2
- Mock method don't work when test from other file fail HOT 4
- async_stub doesn't need to be awaited HOT 1
- mocker.stub() is a coroutine function HOT 1
- feature request: fail on improper use of mock.side_effect HOT 2
- Record multiple calls to spy HOT 2
- How to patch return_value attribute? HOT 2
- The documentation should be clearer about not supporting context managers HOT 1
- Not sure why this is not working HOT 3
- `resetall` does not work when using `create_autospec` HOT 2
- Behavior of spy on class attributes HOT 3
- Call args/kwargs stored in a Spy can be overwritten without intention HOT 1
- test_failure_message_with_no_name fails with 3.11.7/3.12.1 HOT 1
- Failing tests for python 3.12 HOT 1
- Allow for easier import of `mocker.Mock | mocker.MagicMock` types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytest-mock.