pytest 8.2.0 runs `unittest.case.TestCase.__init__` during collecting phase in the same process about pytest HOT 6 CLOSED

Its important to note that adding setup code to the constructor is always completely wrong for testcase subclasses

So your code was always incorrect

It simply didn't trigger before by accident

from pytest.

I just would like to confirm if this is an expected change of pytest 8.2.0 as it somehow seems to be a breaking change. If so, I guess it is worthing mentioning it in the change log https://docs.pytest.org/en/8.2.x/changelog.html. 😊

Yes it was an expected change though I didn't anticipate the issues and didn't consider it to be a breaking change (otherwise I wouldn't have done it in a minor release). I will definitely amend the release notes, I just haven't got to it yet.

from pytest.

As unittest itself collects instances,
Having setup code in the ctor is rightfully unexpected

from pytest.

Is there a reason you are doing these things in __init__ rather than in setUp or similar?

from pytest.

Thanks for the response.

It is true that we can move our logic from __init__ into setUp, and this is exactly what I am experimenting in Azure/azure-cli#28849. However, the code has been there for years and changing it will need some effort.

I just would like to confirm if this is an expected change of pytest 8.2.0 as it somehow seems to be a breaking change. If so, I guess it is worthing mentioning it in the change log https://docs.pytest.org/en/8.2.x/changelog.html. 😊

from pytest.

Thanks a lot @RonnyPfannschmidt for the suggestion. I will make sure to move the logic into setUp.

from pytest.