no validating collection attributes about attrs HOT 7 CLOSED

I guess list_of(), dict_of() validators may be useful.

from attrs.

The overall problem is that while those validators look useful, in practice you usually need more sophisticated validation and end up using a true validation framework anyway (that can be used from within attrs just fine).

So I'm not sure this is really worth adding and whether we should get on the slippery slope of growing an inadequate validation framework that will just lead to people asking for more features and yet us never reach the power of something like voluptuous?

from attrs.

I'm fine with adding anything that's useful to the wiki! So far I had no reason to remove anything.

That said, I believe this ticket has been already fixed in #425! Yeah, I can be inconsistent too. 🙈

from attrs.

This is fairly easy to do if you just write your own validator. There will almost always be a need to do that for when you want to validate not just an object's type, but that it falls in a certain range, e.g. non-negative integer.

from attrs.

A testtools_matches along with the various matchers at http://testtools.readthedocs.io/en/latest/for-test-authors.html#combining-matchers would also address this.

from attrs.

Is this still something that's worth adding ? I was thinking of something like:

If a more generic option is recommended, like container_of with some helpers (as mentioned in the other closed PR) I'd be willing to implement this as long as we define the scope of it and the requirements.
If I gathered all the data from the other PR, would be nice to have something like:

container_of(container_type, validators, empty_ok=True, none_ok=True)
On top of this there could be some helpers as list_of set_of etc.

@hynek could you please comment on this ?

from attrs.

@hynek is this something that's worth having as a separate library, eventually added here https://github.com/python-attrs/attrs/wiki/Extensions-to-attrs that would provide validators to containers ? We have a version currently that allows you to create validators for containers (list_of, set_of, dict_of) plus a generic function that allows you to implement your own container validators at my workplace and I'm willing to open source it, if you consider it could bring some potential value.

Does it makes sense to have this alongside the typing capabilities specified here ?
http://www.attrs.org/en/stable/types.html

from attrs.