Do we want to guarantee deepcopied attributes when converting ? about attrs HOT 8 CLOSED

Eh could you rephrase + elaborate please? I have a nasty head cold and can’t entirely follow. :)

from attrs.

Let me try again :)

As in #28, the speed difference is because we iterate over the attr descriptors using fields, which makes a deepcopy for every field.

In #28, we've fixed it by iterating using inst.__class__.__attrs_attrs__. I was about to prepare a PR to do the same here, but then realized that the deepcopy may have bene intentional in this case. If not, I will be happy to prepare a PR to fix this.

from attrs.

Um this would only matter, if someone would modify the attribute list in their container, right? (which they never should)

from attrs.

Ok, let me prepare a PR then.

What is the rationale for using deepcopy in fields then ?

from attrs.

I find there’s a difference between a public API like fields and misbehaving in an converter. But maybe I’m wrong. :)

from attrs.

do you think you can get it done by say Wed? I’d like to push out a release before PyCon

from attrs.

looks like I could ! Too bad I could not make it up this year at PyCon...

from attrs.

aw :(

from attrs.