Handle Latex API Errors about sir-lancebot HOT 4 CLOSED

We are catching this further up

              try:
                  with open(image_path, "wb") as out_file:
                      await self._generate_image(TEMPLATE.substitute(text=query), out_file)
              except InvalidLatexError as err:
                  embed = discord.Embed(title="Failed to render input.")
                  if err.logs is None:
                      embed.description = "No logs available."
                  else:
                      logs_paste_url = await self._upload_to_pastebin(err.logs)
                      if logs_paste_url:
                          embed.description = f"[View Logs]({logs_paste_url})"
                      else:
                          embed.description = "Couldn't upload logs."
                  await ctx.send(embed=embed)
                  image_path.unlink()
                  return

We say that we couldn't render the input, which I think is enough to close this.

from sir-lancebot.

Sure, I'll assign you.

As for the error message, what you've suggested or something like '' Server encountered an issue, please retry in a moment '' should do the job.

We can discuss this in the PR at the worst case.

from sir-lancebot.

We're only catching the InvalidLatexError, which wont be raised in the case of a 5xx exception (since a ClientResponseError will be raised before the line we raise that error is reached).

Also, I think it's worth distinguishing between errors with a user's input, and error's with the server.

from sir-lancebot.

I would like to work on this issue, yet what would be a good user message in that case ?
I suggest : "Rendering server is unavailable, please try again later"

from sir-lancebot.