Giter VIP home page Giter VIP logo

Comments (7)

shtlrs avatar shtlrs commented on August 15, 2024 1

It should go into the LATEX_ALLOWED_CHANNNELS, since we're talking about allowing the latex command, that'll automatically include it in the override later on.

The help channel isn't in the Channels class, so you would need to add it as well.

from sir-lancebot.

wookie184 avatar wookie184 commented on August 15, 2024

This sounds fine to me, we can always restrict it again if there's an issue.

from sir-lancebot.

matiaslagoevia avatar matiaslagoevia commented on August 15, 2024

I could help with this issue. I'd just need clarification on the finalized approach:

  1. Allow in all channels except X,Y,Z.
  2. Add X,Y,Z to the LATEX_ALLOWED_CHANNELS.

from sir-lancebot.

Ibrahim2750mi avatar Ibrahim2750mi commented on August 15, 2024

I could help with this issue. I'd just need clarification on the finalized approach:

  1. Allow in all channels except X,Y,Z.
  2. Add X,Y,Z to the LATEX_ALLOWED_CHANNELS.

Its the reverse, you add the the channels which are allowed in LATEX_ALLOWED_CHANNELS. So if channel XYZ isn't allowed you don't add it to the LATEX_ALLOWED_CHANNELS. Only allowed channels are to be added to that variable.

from sir-lancebot.

shtlrs avatar shtlrs commented on August 15, 2024

@matiaslagoevia I can assign you if you want to work on this.

The change should be as simple as adding the python help-channel id to the list of allowed channels, just like in the snippet attached to the issue

from sir-lancebot.

matiaslagoevia avatar matiaslagoevia commented on August 15, 2024

@matiaslagoevia I can assign you if you want to work on this.

The change should be as simple as adding the python help-channel id to the list of allowed channels, just like in the snippet attached to the issue

Thanks! I wasn't sure since the OP mentioned two different approaches in the description.

I'd be inclined to add it here, instead of here.

Also, I'm not sure what channel in the list here would be the appropriate one (or if I should add it to that list as well).

from sir-lancebot.

matiaslagoevia avatar matiaslagoevia commented on August 15, 2024

Got it, I have enough context to tackle the issue now. Thank you!

from sir-lancebot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.