Comments (3)
zingale
commented on June 12, 2024
Hi @bcaddy we have a C++ implementation of PLM in our code Castro that you might want to look at:
https://github.com/AMReX-Astro/Castro
nothing jumped out a me looking at your code, so I could suggest that you print out the different components throughout the reconstruction and compare to the values in pyro.
from pyro2.
bcaddy
commented on June 12, 2024
Hi @zingale, thanks! Could you point out where it is in Castro? I'm having trouble finding it.
from pyro2.
bcaddy
commented on June 12, 2024
I found the issue. I didn't realize I wasn't supposed to divide by delta X when computing the slopes. Thanks for you help!
from pyro2.
Related Issues (20)
- make regression testing github action HOT 1
- Add a notice that the docs on readthedocs.io are outdated HOT 2
- Top-level `examples` module can break other packages
- store x2d and y2d as ArrayIndexer objects
- create axisymmetric grid class
- lm_atm-bubble regression test fails with numpy 1.24 HOT 5
- create MHD HLLD Riemann solver
- create MOL MHD solver
- "Latest release" on GitHub release page points at 2014 paper version HOT 1
- Setting PYTHONPATH is unnecessary? HOT 3
- Consider making pyro2 pip-installable HOT 3
- Consider adding support for pyro to yt
- Add _skeleton directory to help make new solvers/problems HOT 1
- add python 3.7 to testing
- well balanced scheme doesn't work anymore? HOT 1
- Error in terminal when animation is running and you click the animation
- Convert CI to GitHub actions
- add widget support to Jupyter notebooks HOT 3
- fix pyro setup.py installation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyro2.