Giter VIP home page Giter VIP logo

Comments (4)

Julian avatar Julian commented on May 11, 2024

Hi.

That looks ok for objects just from taking a quick peek, but how about when
you're validating, say, an array?

from jsonschema.

 avatar commented on May 11, 2024

Good point.

    def validate_minItems(self, mI, instance, schema, property):
        if self._is_type(instance, "array") and len(instance) < mI:
            self._error(u"%r is too short" % (instance,), property)

    def validate_maxItems(self, mI, instance, schema, property):
        if self._is_type(instance, "array") and len(instance) > mI:
            self._error(u"%r is too long" % (instance,), property)

Is there anywhere that traverses inside the array to check the correct value types? I think we'd want to make sure the property name is still passed through.

How do I run your tests again the code update?

How would you approach it? The reason we're developing this is so not only is there human readable error messages, but we can also machine read and know what 'property' has errors, etc.

Cheers

from jsonschema.

Julian avatar Julian commented on May 11, 2024

Is there anywhere that traverses inside the array to check the correct value types? I think we'd want to make sure the property name is still passed through.

That validation would happen inside validate_items (the validation is
basically just like walking a tree, similar to ast.NodeVisitor in case
you're familiar). But, what I meant was, what if your entire instance is
just an array, then you'd have no key / property to store at all. How would
details behave there?

How do I run your tests again the code update?

If you've got tox installed you can just run tox in the root of the
checkout. Otherwise just run your favorite test runner, say trial tests
or nosetests also from the checkout.

How would you approach it? The reason we're developing this is so not only is there human readable error messages, but we can also machine read and know what 'property' has errors, etc.

Yeah, I can definitely appreciate making the errors more structured here
once we can just iron out the behavior for all the cases.

from jsonschema.

 avatar commented on May 11, 2024

Julian,

Can you drop me an email at kevin at mapmy fitness dotcom? Would like to explore something with you...

Cheers,

-Kevin

from jsonschema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.