New HS220 require authentication about python-kasa HOT 5 OPEN

Hi and thanks for reporting! Would you mind contributing a fixture file to our test suite?

from python-kasa.

I found out that by using kasa username and password variable, the authentication is used and its working. So it's seem the code is already in place to have it work!

from python-kasa.

Glad to hear that :-) We have taken a more modular approach so most devices will have at least some sort of support out-of-the-box. If you try kasa feature on it, you may see even more features being available to control than what was possible previously, if you already had older HS220s.

As for the fixture files, those contain anonymized information (you can see examples at https://github.com/python-kasa/python-kasa/tree/master/kasa/tests/fixtures/smart) that is useful to extend the support for new features & it's also used to list supported devices, so having one for the new HS220 would be great!

from python-kasa.

Hello,

I just generate a lot of them (I ran it against all my device). How do I make a pull request now from my ubuntu cli?

Thank you

from python-kasa.

Hi, and thank you for helping us! You could either just upload the files (git status shows the ones that were created, they should be inside the kasa/tests/fixtures/ directory), or try if https://github.com/simonplend/howto-create-pr-with-github-cli works its magic.

In order to commit the changes, you can use git commit -a -m "Add fixtures" to commit all the changed files before trying to create a PR, and we can take it from there.

from python-kasa.