Comments (7)
(I wasn't signed in, but this issue is one that I created)
from rope.
Hi,
angri, I think something like the attached patch should fix
it (I have not tested it).
Thanks,
Ali
from rope.
That patch seems to address the issue.
from rope.
Hi,
Thanks for reporting and testing it. As you reported in
issue #6, AbstractFunction should be pyobjects.AbstractFunction
in my patch. So, angri please update the patch before applying.
Thanks,
Ali
from rope.
Could you please provide some testcase for this issue? I don't know how to reproduce crash.
from rope.
Hi angri,
The first traceback seems to be related to the new
BuiltinUnknown class. It triggered a bug in evaluate.py.
_call_function() should only call get_returned_object()
for instances of AbstractFunction. So the patch I
submitted checked that. But that patch had a small mistake;
AbstractFunction should have been pyobjects.AbstractFunction.
I'm attaching a fixed patch (not tested).
Thanks,
Ali
PS. sorry for changing issue state everytime I post! my
small text-based browser does it automatically ;-)
from rope.
Patch applied.
from rope.
Related Issues (20)
- Inline method refactoring changes variables names after applying the transformation
- Inline method refactoring passes the wrong parameter to the inlined function body
- Rename Field refactoring allows you to rename a field with the same name used in a global method HOT 1
- Rename Field refactoring allows you to use the name of special methods as a new name HOT 1
- Rename Field refactoring allows the use of declared method names as new field names HOT 1
- Rename Field refactoring allows the use of a name that can not be iterable HOT 1
- Rename Field refactoring allows you to rename a class field with class method names HOT 1
- Rename Field refactoring allows you to rename a local field with the method name HOT 1
- Rename Field refactoring allows you to change the method parameter, causing inconsistent override
- Rename Method refactoring allows the use of previously declared field name HOT 1
- Rename Method refactoring allows you to rename a method to a name with an 'internal use' indicator HOT 1
- Rename Method refactoring does not change the name of the super method in the classes that override it
- Rename Method refactoring is allowed in methods of the descriptor protocol
- Rename Method refactoring does not change the calls of the renamed method.
- Rename Method refactoring allowed for methods designed for numeric type emulation
- Rename Method refactoring does not rename all implementations of an abstract method
- Rename Method refactoring allowed for methods defined to implement container objects
- Rename Method refactoring allows you to rename a nested method with a parameter name HOT 1
- Rename refactoring should check whether the target variable exists
- Tests that uses external_fixturepkg shoud run in their own venv
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rope.