Giter VIP home page Giter VIP logo

Comments (5)

briancoutinho avatar briancoutinho commented on June 20, 2024

That's a fair point that data for events does come in with nano second granularity for start and end timestamps.

AFaIK the main constraint is Chrome Trace format. We use these 'X' Complete events to represent the kernels and operators. They unfortunately specify the timing in resolution of microseconds only

There is an extra parameter dur to specify the tracing clock duration of complete events in microseconds. All other parameters are the same as in duration events.

And all timestamsp are in microseconds too

ts: The tracing clock timestamp of the event. The timestamps are provided at microsecond granularity.

https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview

from kineto.

fwenguang avatar fwenguang commented on June 20, 2024

That's a fair point that data for events does come in with nano second granularity for start and end timestamps.

AFaIK the main constraint is Chrome Trace format. We use these 'X' Complete events to represent the kernels and operators. They unfortunately specify the timing in resolution of microseconds only

There is an extra parameter dur to specify the tracing clock duration of complete events in microseconds. All other parameters are the same as in duration events.

And all timestamsp are in microseconds too

ts: The tracing clock timestamp of the event. The timestamps are provided at microsecond granularity.

https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview

Yes, ts and dur is in microseconds granularity. But they can be floating point type as far as i know.

So if there are no other constraints, I think it would be necessary to perform the conversion from nanoseconds(int64) to microseconds(double) only when saving to a Chrome trace file. Using floating-point types for 'ts' and 'dur' would prevent the loss of time in the order of nanoseconds or even hundreds of nanoseconds per event.

Additionally, it need to use relative timestamps for 'ts'.Due to the timestamps in nanoseconds require 19 digits. But double can typically represent around 15-16 significant digits of precision.

from kineto.

briancoutinho avatar briancoutinho commented on June 20, 2024

But they can be floating point type as far as i know.

Oh I didn't know that. We can try that actually.

Additionally, it need to use relative timestamps for 'ts'.Due to the timestamps in nanoseconds require 19 digits. But double can typically represent around 15-16 significant digits of precision.

How about just using a fixed point representation with 3 digits after the decimal point?

from kineto.

fwenguang avatar fwenguang commented on June 20, 2024

How about just using a fixed point representation with 3 digits after the decimal point?

Sorry. I don't fully understand that.Using what filed to save these 3 digits?

If the 'ts' in nanosecond is 1706495062881409718. It was like this before the modification.

{
    "ph": "X", "cat": "kernel", "name": "kernel_name", "pid": 0, "tid": 1,
    "ts": 1706495062881409, "dur": 36,
    "args": {
      ...
    }
  }

What should it be like after the modification?

from kineto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.