Question: Should new model version always become default? about serve HOT 11 CLOSED

Hmm ... fair point. I could that we register a new version only with the intention of using it. We have an API to set default version, in what you are proposing assuming I register a new version only with the intention of using it versus having it present in the model cache. In this case, every new version that I register will then also have to be registered as the new default model.

This flow:

• cur default = 1.0
• register version = 1.1 (cur default = 1.1)
• A/B testing still possible

That Flow:

• cur default = 1.0
• register version = 1.1 (cur default = 1.0)
• set default = 1.1 (cur default = 1.1)

Question boils down to:

"This Flow or That Flow?"

FWIW current impl is less intuitive.

from serve.

I would go with That Flow™. My thinking around this is that the endpoint will be serving models in production, but people will want to benchmark, A/B test, or otherwise evaluate new model versions before switching them to production use, and they won't want to take down a working production system in the meantime.

from serve.

Fix available in #51 branch do_not_set_default_with_register.

from serve.

renamed branch to issue_43. New PR is : #151

from serve.

There's a bug in the PR where the model version string is cast to a Double.

from serve.

I tested the stage_release branch for comparison, and it is also stopping on an exception (which, by the way, does not show a call stack, nor show up in ts_log.log).

The version number must either consistently be a string (and treated as such in all places in code), or it needs to be a double, and that needs to be enforced in the model archiver. (Right now, the model archiver takes any string for a version.) With the common version number schemes that people use, IMO a string makes a lot more sense.

from serve.

Now TorchServe accepts model version as string. The fix is available in the same PR #151

from serve.

One change to unit tests requested on #151

from serve.

Updated the version to represent a string.

from serve.

This looks good, and the unit tests cover the new case of non-Double-parseable model version strings. Please close this issue after merging.

from serve.

PR #171 merged to master

from serve.