Giter VIP home page Giter VIP logo

Comments (9)

harshbafna avatar harshbafna commented on May 15, 2024 1

@fbbradheintz : We agreed to document this and the documentation is available in master branch :
https://github.com/pytorch/serve/blob/master/docs/default_handlers.md

from serve.

fbbradheintz avatar fbbradheintz commented on May 15, 2024

billmurray1

Sample input to induce failure

from serve.

harshbafna avatar harshbafna commented on May 15, 2024

@fbbradheintz @mycpuorg : The pre-processing and post-processing for the default image classification handler is implemented for torchvision's imagenet based models like densenet, resnet etc. Thus we use the standard normalization for imagenet models which is based on RGB images.

We expect the user to implement a custom handler for other image-classification models, for e.g. MNIST digit classifier or other models which are not trained using imagenet dataset, which uses different normalization parameters. We will add a documentation describing the expected input and output of all default handlers.

E.g :

  • default image_classifer expects a RGB image file as input and returns the probability of top 5 results
  • default text_classifier expects a text file as input and returns the classification of the text.

from serve.

mycpuorg avatar mycpuorg commented on May 15, 2024

@harshbafna
We can explicitly say that image_classifier handles only RGB images and so on for other default handlers. That is reasonable, however, it is not OK for the classifier handler to crash. We must handle it as an exception and return an error code at a minimum.

from serve.

fbbradheintz avatar fbbradheintz commented on May 15, 2024

If you can put up the doc change, I'll close this.

from serve.

harshbafna avatar harshbafna commented on May 15, 2024

Added documentation in stage_release branch.

commit : 4ab6f7c

from serve.

fbbradheintz avatar fbbradheintz commented on May 15, 2024

Looks good. Please close after merge.

from serve.

fbbradheintz avatar fbbradheintz commented on May 15, 2024

Regression in the 4/10 build.

from serve.

fbbradheintz avatar fbbradheintz commented on May 15, 2024

Sounds good. Thanks!

from serve.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.