Giter VIP home page Giter VIP logo

Comments (5)

peri044 avatar peri044 commented on June 12, 2024 1

OptimizedModule is an artifact of torch.compile compilation. We don't have a way to save those models. Instead, ir=dynamo is the way to go if you want to serialize models.

The following isn't the recommended workflow. torch_tensorrt.dynamo.export can only take torch.fx.GraphModule as its input.

trt_exp_program = torch_tensorrt.dynamo.export(trt_mod, [dummy_x.half(), dummy_embed.half()], "ep")

The docs you linked isn't updated (we are working on fixing the docs). Please refer to this file https://github.com/pytorch/TensorRT/blob/release/2.2/docsrc/user_guide/saving_models.rst

from tensorrt.

AvivSham avatar AvivSham commented on June 12, 2024

@gs-olive any chance you can help with this?

from tensorrt.

AvivSham avatar AvivSham commented on June 12, 2024

Hi @peri044,

I tried your suggestion (using dynamo as the ir_mode) but ended up with the following error:
torch._dynamo.exc.UserError: Dynamic control flow is not supported at the moment. Please use functorch.experimental.control_flow.cond to explicitly capture the control flow.

dynamo compile does not act like jit.script? shouldn't it handle logic conditions?
What if I want it to act like jit.trace where only the flow activated for the specific input is compiled?

Just a reminder using torch_compile as ir_mode compiles the model but produces OptimizedModule.

If it helps I can share my code and also promoting the pytorch version is an option (if this issue is fixed/supported in later versions).

from tensorrt.

AvivSham avatar AvivSham commented on June 12, 2024

@gs-olive @peri044
Can you please help?

from tensorrt.

gs-olive avatar gs-olive commented on June 12, 2024

Hi - to my knowledge, Torch's Dynamo export tracer works slightly differently to torch.jit.trace, in that torch.jit.trace generally traces only the control flow for the specific input, as you mentioned, and effectively collapses the if/else statements. Dynamo export's tracer can sometimes try to trace without modifying the conditional, which leads to errors like this where it requires a specific tracer-friendly conditional to work.

I believe there are tools to do this "conditional-flattening" in advance - maybe something like torch.fx.experimental.proxy_tensor.make_fx or torch.fx.symbolic_trace with concrete_args specified. Then, once traced with control flow removed, this FX graph can be passed to torch_tensorrt.compile. @peri044 - do you know of any other methods for accomplishing this?

Providing the source code/sample model would be helpful for us to debug further as well.

from tensorrt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.