Giter VIP home page Giter VIP logo

Comments (5)

tyarkoni avatar tyarkoni commented on May 21, 2024

It wouldn't take much work to add that behavior, but I'm not sure how I feel about it. Mainly I worry about feature creep if we start doing things like scanning the data model for already-defined callbacks, etc. It feels a bit inelegant to me to push some of the FSM logic into the data object. That said, I don't feel strongly about it, so let's leave this issue open for now, and if other people weigh in with strong opinions one way or the other, we can re-evaluate.

from transitions.

mayowa avatar mayowa commented on May 21, 2024

+1 I think it would a great idea for on_enter_ and on_exit_ methods to be detected in the model and executed during transitions, Methinks it would make the code a whole lot more readable

from transitions.

tyarkoni avatar tyarkoni commented on May 21, 2024

Okay, then I'm sold. Does someone want to take a stab at a PR? If not, I should be able to get to it in a few days.

from transitions.

mayowa avatar mayowa commented on May 21, 2024

I'll do it and send you a PR

from transitions.

tyarkoni avatar tyarkoni commented on May 21, 2024

Great!

from transitions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.