[FEATURE]: Better logging support for xUnit about boa-constrictor HOT 7 CLOSED

The solution to this is the following:

public class XUnitLogger : AbstractLogger
{
      private readonly ITestOutputHelper output;

      public XUnitLogger(ITestOutputHelper output, LogSeverity severity = LogSeverity.Trace)
          :base(severity)
      {
          this.output = output;
      }

      public override void Close()
      {
          // This logger needs no closing
      }

      protected override void LogRaw(string message, LogSeverity severity = LogSeverity.Info)
      {
          if(severity >= LowestSeverity)
              output.WriteLine(message);
      }
}

public class MyTest
{
        private readonly ITestOutputHelper output;
        public MyTest(ITestOutputHelper output)
        { 
            this.output = output;
        }

        [Fact]
        public void EditIcon_ShouldPutRowInEditMode()
        {
            var test = new Actor("Customer", new XUnitLogger(output));
        }
}

Given the recent architecture changes, where should I place this? At first I considered placing this under Boa.Constrictor.Screenplay however it would require adding an xUnit dependency. Would it be more appropriate to start a Boa.Constrictor.xUnit project?

from boa-constrictor.

@thePantz feel free to fork the repository, get working, and send a pull request!

from boa-constrictor.

@thePantz, this is good stuff. You're absolutely right about the dependency issue. I think I agree with your assessment that we'd want a separate project and package for xUnit to support this.

My questions for you:

• Is this something you'd want to do?
• Do you want this to be part of the main Boa Constrictor repository?

I'd love to collaborate with you on this if you're up for the challenge!

from boa-constrictor.

Yes! I would be happy to contribute! I figure it's a general enough use case that will be useful to others.

Although, I noticed #20 the other day and was wondering if this is still valuable or if it will soon be obsolete

from boa-constrictor.

#20 is still valid but not planned at the moment. I'd say move forward with this xUnit logger for now. We can change things in the future.

from boa-constrictor.

(I'm here to answer questions and offer help along the way if you need it, too!)

from boa-constrictor.

This work was completed as part of #248 !

from boa-constrictor.