The proto files used to generate gRPC types in SDKs are currently <a href="https://git

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Consider publishing proto files via a separate git repo about qdrant-dotnet HOT 3 CLOSED

roji commented on August 22, 2024

Consider publishing proto files via a separate git repo

from qdrant-dotnet.

Comments (3)

russcam commented on August 22, 2024 1

++ this would be helpful.

What would also be useful is if the protos included the agreed c# namespace option, for example

# namespace TBC
option csharp_namespace = "Qdrant.Client.Grpc"

which is patched in when downloading in

qdrant-dotnet/build/Main.cs

Lines 80 to 103 in eaa6249

  // add csharp namespace to proto files if they don't contain one 

  foreach (var file in Directory.EnumerateFiles(protosTagDir)) 

  { 

  var contents = File.ReadAllLines(file).ToList(); 

  if (contents.Any(line => line.Contains("option csharp_namespace"))) 

  continue; 

  var index = 0; 

  for (var i = 0; i < contents.Count; i++) 

  { 

  if (contents[i].StartsWith("syntax") || 

  contents[i].StartsWith("import") || 

  contents[i].StartsWith("package") || 

  contents[i].StartsWith("//") || 

  string.IsNullOrWhiteSpace(contents[i])) 

  continue; 

  index = i; 

  break; 

  } 

  contents.Insert(index, $"option csharp_namespace = \"{project}\";"); 

  File.WriteAllLines(file, contents); 

  }

from qdrant-dotnet.

generall commented on August 22, 2024

Hi @russcam, @roji. We have considered this refactoring a while ago, similar question was raised in similar context:

For example here: qdrant/qdrant#1266

But unfortunately there are quite a few places where this decomposition will disrupt our workflow. There are already set-up processes which rely on current proto structure, and refactoring could easily take months.

As an alternative I propose to take a look at how current clients implement the update process:

There is a very minimal script which can fetch a single sub-directory of qdrant main repo: https://github.com/qdrant/rust-client/blob/master/tools/sync_proto.sh

Versioning is very simple:

the client:master is synced with master of the qdrant/qdrant:master, and client:dev is synced with qdrant/qdrant:dev.
That allows development of the client features before the release of the main project.

It is very easy to setup CI script that would ensure that the repo has latest changes.

When it is time to release, we cherry-pick changes from dev to master and run CI against the latest build.

Regarding c# namespace option, please feel free to PR it into the main repo, I assume it is not going to break any other generators

from qdrant-dotnet.

roji commented on August 22, 2024

But unfortunately there are quite a few places where this decomposition will disrupt our workflow. There are already set-up processes which rely on current proto structure, and refactoring could easily take months.

Just to be clear, I'm only suggesting bringing in the proto files - exactly as they are today - via a git submodule; that means that the directory structure and files stay identical to what they are today (i.e. no refactoring within the protos), and just the fetching/refreshing mechanism changes (i.e. you use git to get the right files rather than a script).

But if this would cause issues on your side we can manage the way things are, of course.

from qdrant-dotnet.

Consider publishing proto files via a separate git repo about qdrant-dotnet HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// add csharp namespace to proto files if they don't contain one
	foreach (var file in Directory.EnumerateFiles(protosTagDir))
	{
	var contents = File.ReadAllLines(file).ToList();
	if (contents.Any(line => line.Contains("option csharp_namespace")))
	continue;

	var index = 0;
	for (var i = 0; i < contents.Count; i++)
	{
	if (contents[i].StartsWith("syntax") \|\|
	contents[i].StartsWith("import") \|\|
	contents[i].StartsWith("package") \|\|
	contents[i].StartsWith("//") \|\|
	string.IsNullOrWhiteSpace(contents[i]))
	continue;

	index = i;
	break;
	}

	contents.Insert(index, $"option csharp_namespace = \"{project}\";");
	File.WriteAllLines(file, contents);
	}