Giter VIP home page Giter VIP logo

Comments (5)

atilag avatar atilag commented on August 19, 2024

There should be no problem, as long as it's faster than Apple's implementation. We should benchmark both and compare, we just haven't yet. The choice was more OpenBLAS vs Apple's. My preference was always OpenBLAS, but seems like on Mac, Apple's implementation is arguably faster, so we changed it despite of the fact that there seems to be some non-standard practices in the latter that cold lead to potential problems, or at least this is what other users of this library have been reported.

from qiskit-aer.

nonhermitian avatar nonhermitian commented on August 19, 2024

My point is that NumPy is a requirement that already is built against a specific blas implimentation. The aer installer should automatically link against that. This gives me, for example, the intel mkl for free. This allows one to test against different blas and time them quite easily by simply changing numpy, for example using the —nomkl flag in conda.

from qiskit-aer.

atilag avatar atilag commented on August 19, 2024

I see that there are versions of Numpy that are linked against OpenBLAS, depending on where Numpy comes from: Pypi -> OpenBlas , Conda -> mkl.
I guess that mkl version is faster for x86 architectures, but we still need to support Power architectures.
Anyway, letting the user choose their desired implementation sounds like a good thing to me.
I'm labeling this issue as an enhancement for now.

from qiskit-aer.

atilag avatar atilag commented on August 19, 2024

With #543 merged, now we can chose which BAS implementation we want to build with.

from qiskit-aer.

mdepasca avatar mdepasca commented on August 19, 2024

It is not clear to me wether qiskit_aer depends completely on numpy (or a set of external packages) or not.
The rationale for the question is:

  • if it does, to use Intel MKL libraries on x86, for me is enough to install an numpy version depending on those libs (Intel optimised provided by Intel);
  • if it does not completely depends on numpy (or a set of external packages), then to use Intel MKL I would need to build from scratch.

from qiskit-aer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.